Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 15890002: Display GL window system binding information in about:gpu (Closed)

Created:
7 years, 7 months ago by Sami
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sail+watch_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Display GL window system binding information in about:gpu This patch adds information about the GL window system binding layer implementation to about:gpu. Depending on which binding layer is used, the following information is displayed: - EGL: vendor, version, extension string - GLX: vendor, version, extension string - WGL: extension string TEST=Check that the above shows up in about:gpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203167

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove code duplication. Fix win build. #

Patch Set 3 : Rebased. #

Patch Set 4 : Fixed typo in unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -0 lines) Patch
M content/browser/gpu/gpu_internals_ui.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/config/gpu_info.h View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/config/gpu_info_collector.cc View 1 2 3 chunks +12 lines, -0 lines 0 comments Download
M gpu/config/gpu_info_unittest.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_egl_api_implementation.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_egl_api_implementation.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M ui/gl/gl_glx_api_implementation.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_glx_api_implementation.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation_android.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation_mac.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation_win.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation_x11.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M ui/gl/gl_wgl_api_implementation.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_wgl_api_implementation.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Sami
Hi Gregg, here's something I've wanted in about:gpu for a while. WDYT?
7 years, 7 months ago (2013-05-23 15:41:31 UTC) #1
greggman
lgtm https://codereview.chromium.org/15890002/diff/1/ui/gl/gl_implementation_x11.cc File ui/gl/gl_implementation_x11.cc (right): https://codereview.chromium.org/15890002/diff/1/ui/gl/gl_implementation_x11.cc#newcode253 ui/gl/gl_implementation_x11.cc:253: EGLDisplay display = eglGetCurrentDisplay(); This piece of code ...
7 years, 7 months ago (2013-05-23 16:22:14 UTC) #2
Sami
Thanks Gregg. Adding joi@ for content/public/common/gpu_info.h and cdn@ for gpu_messages.h. PTAL. On 2013/05/23 16:22:14, greggman ...
7 years, 7 months ago (2013-05-23 19:05:19 UTC) #3
Jói
LGTM for //content/public/common.
7 years, 7 months ago (2013-05-23 20:12:08 UTC) #4
apatrick_chromium
FYI, some of the files in this patch just moved. See https://codereview.chromium.org/15745014/.
7 years, 7 months ago (2013-05-23 20:13:04 UTC) #5
Sami
On 2013/05/23 20:13:04, apatrick_chromium wrote: > FYI, some of the files in this patch just ...
7 years, 7 months ago (2013-05-24 10:17:45 UTC) #6
apatrick_chromium
lgtm
7 years, 7 months ago (2013-05-24 18:05:22 UTC) #7
Sami
cdn@, friendly ping about content/common/gpu/gpu_messages.h. Thanks!
7 years, 6 months ago (2013-05-29 11:38:55 UTC) #8
Cris Neckar
On 2013/05/29 11:38:55, Sami wrote: > cdn@, friendly ping about content/common/gpu/gpu_messages.h. Thanks! IPC changes LGTM
7 years, 6 months ago (2013-05-29 20:20:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/15890002/13001
7 years, 6 months ago (2013-05-30 10:06:16 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-05-30 10:22:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/15890002/40001
7 years, 6 months ago (2013-05-30 10:37:43 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=45197
7 years, 6 months ago (2013-05-30 12:37:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/15890002/40001
7 years, 6 months ago (2013-05-30 12:44:26 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=45229
7 years, 6 months ago (2013-05-30 14:53:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/15890002/40001
7 years, 6 months ago (2013-05-30 14:58:22 UTC) #16
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 17:06:46 UTC) #17
Message was sent while issue was closed.
Change committed as 203167

Powered by Google App Engine
This is Rietveld 408576698