client/cmd/rpc: RPC CLI

client/cmd/rpc: RPC CLI

See doc.go

In this CL stdin is the only way to specify input message.
This will be improved in the next CL.

R=iannucci@chromium.org, estaab@chromium.org
BUG=

Committed: https://github.com/luci/luci-go/commit/26be494dfcda024ef4532fa14fb2228fe2cdcfaa

[nodir, 2016-01-14 23:59:26]

PTAL

option-style input message format is TBD

[nodir, 2016-01-15 00:04:57]

Description was changed from

==========
client/cmd/rpc: RPC CLI

rpc has two commands: call and show.

call
====

call subcommand reads from stdin, sends a request to a specified service
at a specified server in a specifial format (defaults to json) and
prints the response back to stdout.

$ echo '{"name": "Lucy"}' | rpc call localhost:8080 helloworld.Greeter.SayHello
{
        "message": "Hello Lucy"
}

In this CL stdin is the only way to specify input message.
This will be improved in the next CL.

show
====

show subcommand resolves a name and describes the referenced entity
in .proto syntax. If name is not specified, lists available services.

$ rpc show localhost:8080
helloworld.Greeter
discovery.Discovery

$ rpc show localhost:8080 helloworld.Greeter
package helloworld

// The greeting service definition.
service Greeter {
        // Sends a greeting
        rpc SayHello(HelloRequest) returns (HelloReply) {};
}

$ rpc show localhost:8080 helloworld.Greeter.SayHello
package helloworld

// The greeting service definition.
service Greeter {
        // Sends a greeting
        rpc SayHello(HelloRequest) returns (HelloReply) {};
}

// The request message containing the user's name.
message HelloRequest {
        string name = 1;
}

// The response message containing the greetings
message HelloReply {
        string message = 1;
}

$ rpc show localhost:8080 helloworld.HelloReply
package helloworld

// The response message containing the greetings
message HelloReply {
        string message = 1;
}

R=iannucci@chromium.org, estaab@chromium.org
BUG=
==========

to

==========
client/cmd/rpc: RPC CLI

rpc has two commands: call and show.

call
====

call subcommand reads from stdin, sends a request to a specified service
at a specified server in a specifial format (defaults to json) and
prints the response back to stdout.

$ echo '{"name": "Lucy"}' | rpc call :8080 helloworld.Greeter.SayHello
{
        "message": "Hello Lucy"
}

In this CL stdin is the only way to specify input message.
This will be improved in the next CL.

show
====

show subcommand resolves a name and describes the referenced entity
in .proto syntax. If name is not specified, lists available services.

$ rpc show :8080
helloworld.Greeter
discovery.Discovery

$ rpc show :8080 helloworld.Greeter
package helloworld

// The greeting service definition.
service Greeter {
        // Sends a greeting
        rpc SayHello(HelloRequest) returns (HelloReply) {};
}

$ rpc show :8080 helloworld.Greeter.SayHello
package helloworld

// The greeting service definition.
service Greeter {
        // Sends a greeting
        rpc SayHello(HelloRequest) returns (HelloReply) {};
}

// The request message containing the user's name.
message HelloRequest {
        string name = 1;
}

// The response message containing the greetings
message HelloReply {
        string message = 1;
}

$ rpc show :8080 helloworld.HelloReply
package helloworld

// The response message containing the greetings
message HelloReply {
        string message = 1;
}

R=iannucci@chromium.org, estaab@chromium.org
BUG=
==========

[nodir, 2016-01-15 00:11:36]

Description was changed from

==========
client/cmd/rpc: RPC CLI

rpc has two commands: call and show.

call
====

call subcommand reads from stdin, sends a request to a specified service
at a specified server in a specifial format (defaults to json) and
prints the response back to stdout.

$ echo '{"name": "Lucy"}' | rpc call :8080 helloworld.Greeter.SayHello
{
        "message": "Hello Lucy"
}

In this CL stdin is the only way to specify input message.
This will be improved in the next CL.

show
====

show subcommand resolves a name and describes the referenced entity
in .proto syntax. If name is not specified, lists available services.

$ rpc show :8080
helloworld.Greeter
discovery.Discovery

$ rpc show :8080 helloworld.Greeter
package helloworld

// The greeting service definition.
service Greeter {
        // Sends a greeting
        rpc SayHello(HelloRequest) returns (HelloReply) {};
}

$ rpc show :8080 helloworld.Greeter.SayHello
package helloworld

// The greeting service definition.
service Greeter {
        // Sends a greeting
        rpc SayHello(HelloRequest) returns (HelloReply) {};
}

// The request message containing the user's name.
message HelloRequest {
        string name = 1;
}

// The response message containing the greetings
message HelloReply {
        string message = 1;
}

$ rpc show :8080 helloworld.HelloReply
package helloworld

// The response message containing the greetings
message HelloReply {
        string message = 1;
}

R=iannucci@chromium.org, estaab@chromium.org
BUG=
==========

to

==========
client/cmd/rpc: RPC CLI

rpc has two commands: call and show.

call
====

call subcommand reads from stdin, sends a request to a specified service
at a specified server in a specifial format (defaults to json) and
prints the response back to stdout.

$ echo '{"name": "Lucy"}' | rpc call :8080 helloworld.Greeter.SayHello
{
        "message": "Hello Lucy"
}

In this CL stdin is the only way to specify input message.
This will be improved in the next CL.

show
====

show subcommand resolves a name and describes the referenced entity
in .proto syntax. If name is not specified, lists available services.

$ rpc show :8080
helloworld.Greeter
discovery.Discovery

$ rpc show :8080 helloworld.Greeter
// The greeting service definition.
service Greeter {
        // Sends a greeting
        rpc SayHello(HelloRequest) returns (HelloReply) {};
}

$ rpc show :8080 helloworld.Greeter.SayHello
// The greeting service definition.
service Greeter {
        // Sends a greeting
        rpc SayHello(HelloRequest) returns (HelloReply) {};
}

// The request message containing the user's name.
message HelloRequest {
        string name = 1;
}

// The response message containing the greetings
message HelloReply {
        string message = 1;
}

$ rpc show :8080 helloworld.HelloReply
// The response message containing the greetings
message HelloReply {
        string message = 1;
}

R=iannucci@chromium.org, estaab@chromium.org
BUG=
==========

[iannucci, 2016-01-15 03:38:22]

On 2016/01/14 at 23:59:26, nodir wrote:
> PTAL
> 
> option-style input message format is TBD

(will do the rest of the review in a bit)

CL commit message should be in a doc.go somewhere. Commit message should be
shortish.

[iannucci, 2016-01-15 03:45:16]

lgtm

https://chromiumcodereview.appspot.com/1587323003/diff/20001/client/cmd/rpc/c...
File client/cmd/rpc/call.go (right):

https://chromiumcodereview.appspot.com/1587323003/diff/20001/client/cmd/rpc/c...
client/cmd/rpc/call.go:38: server: scheme (http or https) and hostname, e.g.
"https://example.com".
can we ONLY support https?

...

Oh, dev_appserver.... Can we make localhost the only exception?

https://chromiumcodereview.appspot.com/1587323003/diff/20001/client/cmd/rpc/c...
client/cmd/rpc/call.go:151: logging.Infof(c, "<")
do we log to stderr so that you can pipe the output to get valid
binary/json/text proto on stdout?

[nodir, 2016-01-15 18:17:19]

https://chromiumcodereview.appspot.com/1587323003/diff/20001/client/cmd/rpc/c...
File client/cmd/rpc/call.go (right):

https://chromiumcodereview.appspot.com/1587323003/diff/20001/client/cmd/rpc/c...
client/cmd/rpc/call.go:38: server: scheme (http or https) and hostname, e.g.
"https://example.com".
On 2016/01/15 03:45:16, iannucci wrote:
> can we ONLY support https?
> 
> ...
> 
> Oh, dev_appserver.... Can we make localhost the only exception?

Done. Also simplified usage string and parsing function

https://chromiumcodereview.appspot.com/1587323003/diff/20001/client/cmd/rpc/c...
client/cmd/rpc/call.go:151: logging.Infof(c, "<")
On 2016/01/15 03:45:16, iannucci wrote:
> do we log to stderr so that you can pipe the output to get valid
> binary/json/text proto on stdout?

yes to stderr, see
https://chromiumcodereview.appspot.com/1587323003/diff/20001/client/cmd/rpc/m...

[iannucci, 2016-01-15 23:20:09]

lgtm

https://chromiumcodereview.appspot.com/1587323003/diff/60001/client/cmd/rpc/m...
File client/cmd/rpc/main_test.go (right):

https://chromiumcodereview.appspot.com/1587323003/diff/60001/client/cmd/rpc/m...
client/cmd/rpc/main_test.go:59: })
can we add a test for "example.com:8080" too?

[iannucci, 2016-01-15 23:20:31]

On 2016/01/15 23:20:09, iannucci wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/1587323003/diff/60001/client/cmd/rpc/m...
> File client/cmd/rpc/main_test.go (right):
> 
>
https://chromiumcodereview.appspot.com/1587323003/diff/60001/client/cmd/rpc/m...
> client/cmd/rpc/main_test.go:59: })
> can we add a test for "example.com:8080" too?

Oh, still need to fix doc/CL description situation (see msg #4)

[nodir, 2016-01-15 23:39:13]

Description was changed from

==========
client/cmd/rpc: RPC CLI

rpc has two commands: call and show.

call
====

call subcommand reads from stdin, sends a request to a specified service
at a specified server in a specifial format (defaults to json) and
prints the response back to stdout.

$ echo '{"name": "Lucy"}' | rpc call :8080 helloworld.Greeter.SayHello
{
        "message": "Hello Lucy"
}

In this CL stdin is the only way to specify input message.
This will be improved in the next CL.

show
====

show subcommand resolves a name and describes the referenced entity
in .proto syntax. If name is not specified, lists available services.

$ rpc show :8080
helloworld.Greeter
discovery.Discovery

$ rpc show :8080 helloworld.Greeter
// The greeting service definition.
service Greeter {
        // Sends a greeting
        rpc SayHello(HelloRequest) returns (HelloReply) {};
}

$ rpc show :8080 helloworld.Greeter.SayHello
// The greeting service definition.
service Greeter {
        // Sends a greeting
        rpc SayHello(HelloRequest) returns (HelloReply) {};
}

// The request message containing the user's name.
message HelloRequest {
        string name = 1;
}

// The response message containing the greetings
message HelloReply {
        string message = 1;
}

$ rpc show :8080 helloworld.HelloReply
// The response message containing the greetings
message HelloReply {
        string message = 1;
}

R=iannucci@chromium.org, estaab@chromium.org
BUG=
==========

to

==========
client/cmd/rpc: RPC CLI

rpc has two commands: call and show.

call
====

call subcommand reads from stdin, sends a request to a specified service
at a specified server in a special format (defaults to json) and
prints the response back to stdout.

$ echo '{"name": "Lucy"}' | rpc call :8080 helloworld.Greeter.SayHello
{
        "message": "Hello Lucy"
}

In this CL stdin is the only way to specify input message.
This will be improved in the next CL.

show
====

show subcommand resolves a name and describes the referenced entity
in proto-like syntax. If name is not specified, lists available services.

$ rpc show :8080
helloworld.Greeter
discovery.Discovery

$ rpc show :8080 helloworld.Greeter
// The greeting service definition.
service Greeter {
        // Sends a greeting
        rpc SayHello(HelloRequest) returns (HelloReply) {};
}

$ rpc show :8080 helloworld.Greeter.SayHello
// The greeting service definition.
service Greeter {
        // Sends a greeting
        rpc SayHello(HelloRequest) returns (HelloReply) {};
}

// The request message containing the user's name.
message HelloRequest {
        string name = 1;
}

// The response message containing the greetings
message HelloReply {
        string message = 1;
}

$ rpc show :8080 helloworld.HelloReply
// The response message containing the greetings
message HelloReply {
        string message = 1;
}

R=iannucci@chromium.org, estaab@chromium.org
BUG=
==========

[nodir, 2016-01-15 23:43:22]

Description was changed from

==========
client/cmd/rpc: RPC CLI

rpc has two commands: call and show.

call
====

call subcommand reads from stdin, sends a request to a specified service
at a specified server in a special format (defaults to json) and
prints the response back to stdout.

$ echo '{"name": "Lucy"}' | rpc call :8080 helloworld.Greeter.SayHello
{
        "message": "Hello Lucy"
}

In this CL stdin is the only way to specify input message.
This will be improved in the next CL.

show
====

show subcommand resolves a name and describes the referenced entity
in proto-like syntax. If name is not specified, lists available services.

$ rpc show :8080
helloworld.Greeter
discovery.Discovery

$ rpc show :8080 helloworld.Greeter
// The greeting service definition.
service Greeter {
        // Sends a greeting
        rpc SayHello(HelloRequest) returns (HelloReply) {};
}

$ rpc show :8080 helloworld.Greeter.SayHello
// The greeting service definition.
service Greeter {
        // Sends a greeting
        rpc SayHello(HelloRequest) returns (HelloReply) {};
}

// The request message containing the user's name.
message HelloRequest {
        string name = 1;
}

// The response message containing the greetings
message HelloReply {
        string message = 1;
}

$ rpc show :8080 helloworld.HelloReply
// The response message containing the greetings
message HelloReply {
        string message = 1;
}

R=iannucci@chromium.org, estaab@chromium.org
BUG=
==========

to

==========
client/cmd/rpc: RPC CLI

See doc.go

In this CL stdin is the only way to specify input message.
This will be improved in the next CL.

R=iannucci@chromium.org, estaab@chromium.org
BUG=
==========

[nodir, 2016-01-15 23:47:26]

Moved CL description to doc.go

https://codereview.chromium.org/1587323003/diff/60001/client/cmd/rpc/main_tes...
File client/cmd/rpc/main_test.go (right):

https://codereview.chromium.org/1587323003/diff/60001/client/cmd/rpc/main_tes...
client/cmd/rpc/main_test.go:59: })
On 2016/01/15 23:20:09, iannucci wrote:
> can we add a test for "example.com:8080" too?

Done.

[iannucci, 2016-01-15 23:50:31]

lgtm

[nodir, 2016-01-16 00:55:53]

The CQ bit was checked by nodir@chromium.org

[nodir, 2016-01-16 00:55:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/1587323003/#ps100001
(title: "rebased")

[commit-bot: I haz the power, 2016-01-16 00:55:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587323003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587323003/100001

[commit-bot: I haz the power, 2016-01-16 00:59:51]

Description was changed from

==========
client/cmd/rpc: RPC CLI

See doc.go

In this CL stdin is the only way to specify input message.
This will be improved in the next CL.

R=iannucci@chromium.org, estaab@chromium.org
BUG=
==========

to

==========
client/cmd/rpc: RPC CLI

See doc.go

In this CL stdin is the only way to specify input message.
This will be improved in the next CL.

R=iannucci@chromium.org, estaab@chromium.org
BUG=

Committed:
https://github.com/luci/luci-go/commit/26be494dfcda024ef4532fa14fb2228fe2cdcfaa
==========

[commit-bot: I haz the power, 2016-01-16 00:59:51]

Committed patchset #6 (id:100001) as
https://github.com/luci/luci-go/commit/26be494dfcda024ef4532fa14fb2228fe2cdcfaa