Issue 15867003: Change ComponentLoader::AddOrReplace to return an empty string on failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15867003: Change ComponentLoader::AddOrReplace to return an empty string on failure. (Closed)

Created:
7 years, 7 months ago by Tim Song

Modified:
7 years, 6 months ago

Reviewers:
achuithb, asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Change ComponentLoader::AddOrReplace to return an empty string on failure. The function's signature states it returns a std::string, so it shouldn't NULL on failure. This is also consistent with the other Add functions. TEST=unit test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202744

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	chrome/browser/extensions/component_loader.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/extensions/component_loader_unittest.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Tim Song

Please take a look. I split this change from codereview.chromium.org/15937003.

7 years, 7 months ago (2013-05-23 23:41:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/15867003/1

7 years, 6 months ago (2013-05-28 20:34:35 UTC) #4

Message was sent while issue was closed.

Change committed as 202744

Expand Messages | Collapse Messages