chrome/browser/extensions/component_loader.cc - Issue 15867003: Change ComponentLoader::AddOrReplace to return an empty string on failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/component_loader.cc

Issue 15867003: Change ComponentLoader::AddOrReplace to return an empty string on failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/component_loader.cc

diff --git a/chrome/browser/extensions/component_loader.cc b/chrome/browser/extensions/component_loader.cc

index a63c7285d409e6094cee9fd30a48f8bb53d3431f..6fa3469728d2d32a26f74471fbcde1a2a5cadcf5 100644

--- a/chrome/browser/extensions/component_loader.cc

+++ b/chrome/browser/extensions/component_loader.cc

@@ -167,7 +167,7 @@ std::string ComponentLoader::AddOrReplace(const base::FilePath& path) {

if (!manifest) {

LOG(ERROR) << "Could not load extension from '" <<

absolute_path.value() << "'. " << error;

- return NULL;

+ return std::string();

}

Remove(GenerateId(manifest.get(), absolute_path));

« no previous file with comments | « no previous file | chrome/browser/extensions/component_loader_unittest.cc » ('j') | no next file with comments »