Rename 'harddisk' to 'fixed' for storage unit type

[SystemInfo API] Rename 'harddisk' to 'fixed' for storage unit type

TBR=benwells@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202046

[Hongbo Min, 2013-05-23 09:00:14]

vandebo@, since the systemInfo.storage will be moved out of experimental
namespace, this patch is an improvement for API definitions. The 'harddisk' is
replaced by 'fixed' since the 'harddisk' is a little confused, for example, a
removable USB mass storage is also considered as a hard disk. Pls have a review.
Thanks.

[Hongbo Min, 2013-05-23 09:53:32]

On 2013/05/23 09:00:14, Hongbo Min wrote:
> vandebo@, since the systemInfo.storage will be moved out of experimental
> namespace, this patch is an improvement for API definitions. The 'harddisk' is
> replaced by 'fixed' since the 'harddisk' is a little confused, for example, a
> removable USB mass storage is also considered as a hard disk. Pls have a
review.
> Thanks.

vandeo@, is it enough to present 3 types (fixed, removable and unknown) for
storage device? I found the StorageInfo definition also takes MTP device into
consideration.

[vandebo (ex-Chrome), 2013-05-23 15:49:44]

Some nits

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
File
chrome/browser/extensions/api/system_info_storage/storage_info_provider_linux_unittest.cc
(right):

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
chrome/browser/extensions/api/system_info_storage/storage_info_provider_linux_unittest.cc:42:
{ "/boot", "fixed", 100, 50 },
Use the constants here.

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
File
chrome/browser/extensions/api/system_info_storage/storage_info_provider_unittest.cc
(right):

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
chrome/browser/extensions/api/system_info_storage/storage_info_provider_unittest.cc:38:
{"C:", "unknown", 1000, 10, 0},
Use constants

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
File
chrome/browser/extensions/api/system_info_storage/storage_info_provider_win.cc
(right):

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
chrome/browser/extensions/api/system_info_storage/storage_info_provider_win.cc:22:
class StorageInfoProviderWin : public StorageInfoProvider {
These classes should probably move over to using StorageMonitor instead of
querying for the information directly.  Of course that should be done in a
different CL.

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
File
chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc
(right):

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc:34:
{"0xbeaf", "unknown", 4098, 1000, 0},
Use constants

https://codereview.chromium.org/15846002/diff/10001/chrome/common/extensions/...
File chrome/common/extensions/api/experimental_system_info_storage.idl (right):

https://codereview.chromium.org/15846002/diff/10001/chrome/common/extensions/...
chrome/common/extensions/api/experimental_system_info_storage.idl:8: // The
storage has a fixed media, e.g. hard disk or flash drive.
nit: The storage has fixed media, i.e. hard disk or SSD.

https://codereview.chromium.org/15846002/diff/10001/chrome/common/extensions/...
chrome/common/extensions/api/experimental_system_info_storage.idl:10: // The
storage has a removable media, e.g. USB mass storage.
nit: The storage is removable, i.e. USB flash drive.

https://codereview.chromium.org/15846002/diff/10001/chrome/common/extensions/...
chrome/common/extensions/api/experimental_system_info_storage.idl:12: // The
storage has an unknown storage media type.
nit: The storage type is unknown.

[Hongbo Min, 2013-05-24 01:03:14]

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
File
chrome/browser/extensions/api/system_info_storage/storage_info_provider_linux_unittest.cc
(right):

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
chrome/browser/extensions/api/system_info_storage/storage_info_provider_linux_unittest.cc:42:
{ "/boot", "fixed", 100, 50 },
On 2013/05/23 15:49:44, vandebo wrote:
> Use the constants here.

Done.

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
File
chrome/browser/extensions/api/system_info_storage/storage_info_provider_unittest.cc
(right):

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
chrome/browser/extensions/api/system_info_storage/storage_info_provider_unittest.cc:38:
{"C:", "unknown", 1000, 10, 0},
On 2013/05/23 15:49:44, vandebo wrote:
> Use constants

Done.

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
File
chrome/browser/extensions/api/system_info_storage/storage_info_provider_win.cc
(right):

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
chrome/browser/extensions/api/system_info_storage/storage_info_provider_win.cc:22:
class StorageInfoProviderWin : public StorageInfoProvider {
On 2013/05/23 15:49:44, vandebo wrote:
> These classes should probably move over to using StorageMonitor instead of
> querying for the information directly.  Of course that should be done in a
> different CL.

Yes, this is what I am working on.

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
File
chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc
(right):

https://codereview.chromium.org/15846002/diff/10001/chrome/browser/extensions...
chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc:34:
{"0xbeaf", "unknown", 4098, 1000, 0},
On 2013/05/23 15:49:44, vandebo wrote:
> Use constants

Done.

https://codereview.chromium.org/15846002/diff/10001/chrome/common/extensions/...
File chrome/common/extensions/api/experimental_system_info_storage.idl (right):

https://codereview.chromium.org/15846002/diff/10001/chrome/common/extensions/...
chrome/common/extensions/api/experimental_system_info_storage.idl:8: // The
storage has a fixed media, e.g. hard disk or flash drive.
On 2013/05/23 15:49:44, vandebo wrote:
> nit: The storage has fixed media, i.e. hard disk or SSD.

Done.

https://codereview.chromium.org/15846002/diff/10001/chrome/common/extensions/...
chrome/common/extensions/api/experimental_system_info_storage.idl:10: // The
storage has a removable media, e.g. USB mass storage.
On 2013/05/23 15:49:44, vandebo wrote:
> nit: The storage is removable, i.e. USB flash drive.

Done.

https://codereview.chromium.org/15846002/diff/10001/chrome/common/extensions/...
chrome/common/extensions/api/experimental_system_info_storage.idl:12: // The
storage has an unknown storage media type.
On 2013/05/23 15:49:44, vandebo wrote:
> nit: The storage type is unknown.

Done.

[vandebo (ex-Chrome), 2013-05-24 01:16:25]

LGTM

https://codereview.chromium.org/15846002/diff/22001/chrome/browser/extensions...
File
chrome/browser/extensions/api/system_info_storage/storage_info_provider_unittest.cc
(right):

https://codereview.chromium.org/15846002/diff/22001/chrome/browser/extensions...
chrome/browser/extensions/api/system_info_storage/storage_info_provider_unittest.cc:38:
{"C:", "unknown", 1000, 10, 0},
These should use constants as well.

[commit-bot: I haz the power, 2013-05-24 01:22:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hongbo.min@intel.com/15846002/27001

[commit-bot: I haz the power, 2013-05-24 02:49:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hongbo.min@intel.com/15846002/42001

[benwells, 2013-05-24 03:25:02]

lgtm

[commit-bot: I haz the power, 2013-05-24 07:58:26]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-05-24 09:05:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hongbo.min@intel.com/15846002/42001

[commit-bot: I haz the power, 2013-05-24 10:40:28]

Change committed as 202046