Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1584393003: Precompilation: omit pc descriptors without a try index. (Closed)

Created:
4 years, 11 months ago by rmacnak
Modified:
4 years, 11 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Precompilation: omit pc descriptors without a try index. precompiled dart2js x64 24749045 -> 23713811 (-4.18%) R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/238c01b943d75ffb77d7919b536b0193f4ecdcb5

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M runtime/vm/code_descriptors.cc View 1 2 chunks +16 lines, -9 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 11 months ago (2016-01-15 21:48:38 UTC) #2
Florian Schneider
lgtm https://chromiumcodereview.appspot.com/1584393003/diff/20001/runtime/vm/code_descriptors.cc File runtime/vm/code_descriptors.cc (right): https://chromiumcodereview.appspot.com/1584393003/diff/20001/runtime/vm/code_descriptors.cc#newcode20 runtime/vm/code_descriptors.cc:20: if (Compiler::allow_recompilation() || try_index != -1) { if ...
4 years, 11 months ago (2016-01-19 20:19:48 UTC) #3
rmacnak
4 years, 11 months ago (2016-01-19 22:53:27 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
238c01b943d75ffb77d7919b536b0193f4ecdcb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698