Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15841004: [Binding] Support primitive type for union member (Closed)

Created:
7 years, 7 months ago by kojih
Modified:
7 years, 7 months ago
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, Nate Chapin, alancutter (OOO until 2018)
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

[Binding] Support primitive type for union member Support primitive type such as unsigned long for union member. Now we can write in IDL: getter (Node or unsigned long) (DOMString name); R=haraken@chromium.org BUG=240176 TEST=TestInterface.idl Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151167

Patch Set 1 #

Patch Set 2 : correct base #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : nit #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -22 lines) Patch
M Source/bindings/scripts/CodeGeneratorV8.pm View 1 2 3 3 chunks +10 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/html/HTMLAllCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAllCollection.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlsCollection.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionsCollection.cpp View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
kojih
r? https://codereview.chromium.org/15841004/diff/8001/Source/bindings/tests/results/V8TestInterface.cpp File Source/bindings/tests/results/V8TestInterface.cpp (right): https://codereview.chromium.org/15841004/diff/8001/Source/bindings/tests/results/V8TestInterface.cpp#newcode540 Source/bindings/tests/results/V8TestInterface.cpp:540: if (element0Enabled && !!element0) (copied from https://codereview.chromium.org/15724005/) >Just ...
7 years, 7 months ago (2013-05-23 09:23:09 UTC) #1
haraken
LGTM.
7 years, 7 months ago (2013-05-23 09:44:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kojih@chromium.org/15841004/8001
7 years, 7 months ago (2013-05-23 11:16:14 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9558
7 years, 7 months ago (2013-05-23 12:10:52 UTC) #4
haraken
https://chromiumcodereview.appspot.com/15841004/diff/8001/Source/core/html/HTMLOptionsCollection.h File Source/core/html/HTMLOptionsCollection.h (right): https://chromiumcodereview.appspot.com/15841004/diff/8001/Source/core/html/HTMLOptionsCollection.h#newcode48 Source/core/html/HTMLOptionsCollection.h:48: void anonymousNamedGetter(const AtomicString& name, bool& returnValue1Enabled, RefPtr<NodeList>&, bool& returnValue2Enabled, ...
7 years, 7 months ago (2013-05-23 12:11:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kojih@chromium.org/15841004/21001
7 years, 7 months ago (2013-05-24 02:09:27 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9818
7 years, 7 months ago (2013-05-24 03:02:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kojih@chromium.org/15841004/21001
7 years, 7 months ago (2013-05-24 04:09:36 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9851
7 years, 7 months ago (2013-05-24 05:07:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kojih@chromium.org/15841004/21001
7 years, 7 months ago (2013-05-24 05:20:15 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9874
7 years, 7 months ago (2013-05-24 06:12:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kojih@chromium.org/15841004/21001
7 years, 7 months ago (2013-05-24 06:46:22 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9900
7 years, 7 months ago (2013-05-24 07:30:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kojih@chromium.org/15841004/46001
7 years, 7 months ago (2013-05-24 09:45:12 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9981
7 years, 7 months ago (2013-05-24 11:15:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kojih@chromium.org/15841004/46001
7 years, 7 months ago (2013-05-24 14:00:38 UTC) #16
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10067
7 years, 7 months ago (2013-05-24 15:42:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kojih@chromium.org/15841004/46001
7 years, 7 months ago (2013-05-27 01:11:25 UTC) #18
commit-bot: I haz the power
7 years, 7 months ago (2013-05-27 03:35:01 UTC) #19
Message was sent while issue was closed. 
Change committed as 151167

Powered by Google App Engine
This is Rietveld 408576698