chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc - Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_isolatedapp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

index 0b4af1f4c08d00489a405cde1a23932208688abc..e6f5eb8c820733dfaa5da37a4f213fa6d18686b2 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

@@ -100,9 +100,9 @@ TEST_F(InitValueManifestTest, InitFromValueValid) {

// Test with an options page.

extension = LoadAndExpectSuccess("init_valid_options.json");

EXPECT_EQ("chrome-extension",

- ManifestURL::GetOptionsPage(extension).scheme());

+ ManifestURL::GetOptionsPage(extension.get()).scheme());

EXPECT_EQ("/options.html",

- ManifestURL::GetOptionsPage(extension).path());

+ ManifestURL::GetOptionsPage(extension.get()).path());

Testcase testcases[] = {

// Test that an empty list of page actions does not stop a browser action