chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc - Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Unified Diff: chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc ('k') | chrome/common/extensions/manifest_handlers/shared_module_manifest_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc

diff --git a/chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc b/chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc

index 1af834ef15c1cc0ea21df144acc3ea6cedddbf6e..e24d4f65a0b9df63db60e71c31b18dbaacefb226 100644

--- a/chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc

+++ b/chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc

@@ -29,9 +29,10 @@ class ExternallyConnectableTest : public ExtensionManifestTest {

TEST_F(ExternallyConnectableTest, IDsAndMatches) {

scoped_refptr<Extension> extension =

LoadAndExpectSuccess("externally_connectable_ids_and_matches.json");

- ASSERT_TRUE(extension);

+ ASSERT_TRUE(extension.get());

- ExternallyConnectableInfo* info = ExternallyConnectableInfo::Get(extension);

+ ExternallyConnectableInfo* info =

+ ExternallyConnectableInfo::Get(extension.get());

ASSERT_TRUE(info);

EXPECT_THAT(info->ids, ElementsAre("abcdefghijklmnopabcdefghijklmnop",

@@ -86,9 +87,10 @@ TEST_F(ExternallyConnectableTest, IDsAndMatches) {

TEST_F(ExternallyConnectableTest, IDs) {

scoped_refptr<Extension> extension =

LoadAndExpectSuccess("externally_connectable_ids.json");

- ASSERT_TRUE(extension);

+ ASSERT_TRUE(extension.get());

- ExternallyConnectableInfo* info = ExternallyConnectableInfo::Get(extension);

+ ExternallyConnectableInfo* info =

+ ExternallyConnectableInfo::Get(extension.get());

ASSERT_TRUE(info);

EXPECT_THAT(info->ids, ElementsAre("abcdefghijklmnopabcdefghijklmnop",

@@ -102,9 +104,10 @@ TEST_F(ExternallyConnectableTest, IDs) {

TEST_F(ExternallyConnectableTest, Matches) {

scoped_refptr<Extension> extension =

LoadAndExpectSuccess("externally_connectable_matches.json");

- ASSERT_TRUE(extension);

+ ASSERT_TRUE(extension.get());

- ExternallyConnectableInfo* info = ExternallyConnectableInfo::Get(extension);

+ ExternallyConnectableInfo* info =

+ ExternallyConnectableInfo::Get(extension.get());

ASSERT_TRUE(info);

EXPECT_THAT(info->ids, ElementsAre());

@@ -139,9 +142,10 @@ TEST_F(ExternallyConnectableTest, Matches) {

TEST_F(ExternallyConnectableTest, AllIDs) {

scoped_refptr<Extension> extension =

LoadAndExpectSuccess("externally_connectable_all_ids.json");

- ASSERT_TRUE(extension);

+ ASSERT_TRUE(extension.get());

- ExternallyConnectableInfo* info = ExternallyConnectableInfo::Get(extension);

+ ExternallyConnectableInfo* info =

+ ExternallyConnectableInfo::Get(extension.get());

ASSERT_TRUE(info);

EXPECT_THAT(info->ids, ElementsAre("abcdefghijklmnopabcdefghijklmnop",