Make file_util::CreateDirectory return an error, not just a bool

Make CreateDirectory return an error code instead of just a bool.

Make use of the new error code in IndexedDB, where we'll
histogram which errors can be recovered from by retrying
and which can't.

We're going to try retrying CreateDirectory because LevelDB
doesn't pay attention to what env_->CreateDir returns and a
frequent error on the next operation (locking the lock file)
is that the directory doesn't exist. I want to find out
what's causing the directories to not be created in the
first place, and which errors can be considered ephemeral.

BUG=225051
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205386

[dgrogan, 2013-06-06 23:40:00]

Josh or Alec, could you review the IDB part before I get jar@ to review base/ ?

[alecflett, 2013-06-06 23:43:16]

On 2013/06/06 23:40:00, dgrogan wrote:
> Josh or Alec, could you review the IDB part before I get jar@ to review base/
?

lgtm

[dgrogan, 2013-06-06 23:49:39]

Jim, could you review this?

[jar (doing other things), 2013-06-07 23:32:49]

https://codereview.chromium.org/15812007/diff/2001/base/file_util_win.cc
File base/file_util_win.cc (right):

https://codereview.chromium.org/15812007/diff/2001/base/file_util_win.cc#newc...
base/file_util_win.cc:447: *error =
base::LastErrorToPlatformFileError(error_code);
I think you forget to check for a null pointer.

https://codereview.chromium.org/15812007/diff/2001/third_party/leveldatabase/...
File third_party/leveldatabase/env_chromium.cc (right):

https://codereview.chromium.org/15812007/diff/2001/third_party/leveldatabase/...
third_party/leveldatabase/env_chromium.cc:605: }
nit: No need for curlies around this one line result on line 604.  The file is
mostly consistent in not using curlies for this pattern.

[dgrogan, 2013-06-07 23:35:49]

https://codereview.chromium.org/15812007/diff/2001/base/file_util_win.cc
File base/file_util_win.cc (right):

https://codereview.chromium.org/15812007/diff/2001/base/file_util_win.cc#newc...
base/file_util_win.cc:447: *error =
base::LastErrorToPlatformFileError(error_code);
On 2013/06/07 23:32:49, jar wrote:
> I think you forget to check for a null pointer.

Fixed.

https://codereview.chromium.org/15812007/diff/2001/third_party/leveldatabase/...
File third_party/leveldatabase/env_chromium.cc (right):

https://codereview.chromium.org/15812007/diff/2001/third_party/leveldatabase/...
third_party/leveldatabase/env_chromium.cc:605: }
On 2013/06/07 23:32:49, jar wrote:
> nit: No need for curlies around this one line result on line 604.  The file is
> mostly consistent in not using curlies for this pattern.

Done.

[jar (doing other things), 2013-06-10 03:38:04]

lgtm

[commit-bot: I haz the power, 2013-06-10 15:40:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/15812007/11001

[commit-bot: I haz the power, 2013-06-10 16:19:36]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-10 18:07:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/15812007/43001

[commit-bot: I haz the power, 2013-06-10 20:12:50]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-06-10 20:15:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/15812007/43001

[commit-bot: I haz the power, 2013-06-11 03:50:28]

Change committed as 205386