Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: third_party/leveldatabase/env_chromium.cc

Issue 15812007: Make file_util::CreateDirectory return an error, not just a bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: call the right function on windows Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/file_util_win.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/leveldatabase/env_chromium.cc
diff --git a/third_party/leveldatabase/env_chromium.cc b/third_party/leveldatabase/env_chromium.cc
index 1d2a74e2c6f68cf1eb86d42c94bacbd0bef36bb1..71a5c88077b9bb312173f2be6e235b8b14c922a1 100644
--- a/third_party/leveldatabase/env_chromium.cc
+++ b/third_party/leveldatabase/env_chromium.cc
@@ -616,10 +616,14 @@ Status ChromiumEnv::DeleteFile(const std::string& fname) {
Status ChromiumEnv::CreateDir(const std::string& name) {
Status result;
- if (!::file_util::CreateDirectory(CreateFilePath(name))) {
- result = MakeIOError(name, "Could not create directory.", kCreateDir);
- RecordErrorAt(kCreateDir);
- }
+ base::PlatformFileError error = base::PLATFORM_FILE_OK;
+ Retrier retrier(kCreateDir, this);
+ do {
+ if (::file_util::CreateDirectoryAndGetError(CreateFilePath(name), &error))
+ return result;
+ } while (retrier.ShouldKeepTrying(error));
+ result = MakeIOError(name, "Could not create directory.", kCreateDir);
+ RecordErrorAt(kCreateDir);
return result;
}
« no previous file with comments | « base/file_util_win.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698