Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15798019: Use a direct include of strings headers in chrome/browser/chromeos/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, derat+watch_chromium.org, tbarzic+watch_chromium.org, tfarina, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, nona+watch_chromium.org, rginda+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in chrome/browser/chromeos/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205469

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -149 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/camera_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/contacts/contact_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/contacts/gdata_contacts_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/contacts/gdata_contacts_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/cert_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/cert_library.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/native_network_parser.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/network_parser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/customization_document.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/dbus/printer_service_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_app_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/job_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/job_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/logging.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_entry_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/search_metadata_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_handler_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_notifications.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/external_protocol_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/external_protocol_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/imageburner/burn_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/textinput_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/locale_change_guard.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/default_user_images.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/default_user_images.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/help_app_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/hwid_checker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/language_list.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/language_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_display.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/managed/locally_managed_user_creation_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/managed/locally_managed_user_creation_flow.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/managed/managed_user_authenticator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/merge_session_load_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/merge_session_throttle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/mock_url_fetchers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/oauth2_login_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/oauth2_login_verifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/oauth2_token_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/proxy_settings_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker_tester.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen_actor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/screen_context.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/version_info_updater.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/memory/oom_priority_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/memory/oom_priority_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/memory/oom_priority_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/mobile/mobile_activator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/network_config_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/app_pack_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/policy_oauth2_token_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/proxy_cros_settings_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/cros_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/system_settings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/sim_dialog_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/network_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/input_device_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/syslogs_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/timezone_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/timezone_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/lsb_release_log_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/version_loader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/web_socket_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/15798019/1
7 years, 6 months ago (2013-06-10 15:15:42 UTC) #1
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=48106
7 years, 6 months ago (2013-06-10 16:36:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/15798019/1
7 years, 6 months ago (2013-06-10 16:53:01 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, chrome_frame_net_tests, ...
7 years, 6 months ago (2013-06-10 21:52:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/15798019/22002
7 years, 6 months ago (2013-06-10 22:03:16 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 08:03:38 UTC) #6
Message was sent while issue was closed. 
Change committed as 205469

Powered by Google App Engine
This is Rietveld 408576698