net_watcher does not build in Ubuntu 13.04

net_watcher does not build in Ubuntu 13.04

This is due to a deprecation warning in glib. Added a flag to suppress deprecation warnings.
BUG=245658
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203873

[yael.aharon1, 2013-05-31 15:00:17]

Could you please review? thanks!

[jar (doing other things), 2013-05-31 17:13:32]

Q: Do we need the call to g_type_init() anymore?  Why can't we get rid of it,
rather than silencing the error?

[yael.aharon1, 2013-05-31 17:22:55]

On 2013/05/31 17:13:32, jar wrote:
> Q: Do we need the call to g_type_init() anymore?  Why can't we get rid of it,
> rather than silencing the error?

This was added in https://chromiumcodereview.appspot.com/11308069 , in order to
make net_watcher work in gnome, so I believe it is needed.
Please see also https://code.google.com/p/chromium/issues/detail?id=146409 about
the same issue.

[yael.aharon1, 2013-05-31 17:51:51]

I looked at /usr/include/glib-2.0/gobject/gtype.h and indeed there is a comment
that with glib 2.36, g_init_type() is not needed anymore.
From https://launchpad.net/ubuntu/quantal/+package/libglib2.0-0 I see that
Ubuntu 12.10 supports only glib 2.34, and from
https://launchpad.net/ubuntu/raring/+package/libglib2.0-0 I see that Ubuntu
13.04 supports glib 2.36. Unless everybody (who use Ubuntu) switch to Ubuntu
13.04, this call is still needed.

[jar (doing other things), 2013-05-31 18:41:29]

I wasn't dead sure about this syntax shown below... but it might work as
written.

https://codereview.chromium.org/15792013/diff/1/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/15792013/diff/1/net/net.gyp#newcode2468
net/net.gyp:2468: '-Wno-deprecated-declarations',
How about bracketing the offending lines with:


#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
    g_type_init();
#pragma GCC diagnostic pop

That, plus a comment, would make it clearer why we have this, and give us a good
chance of getting rid of the code some day.

It would also allow other deprecations to be illuminated (if they appear).

WDYT?  Would that work?

[yael.aharon1, 2013-05-31 19:54:16]

On 2013/05/31 18:41:29, jar wrote:
> I wasn't dead sure about this syntax shown below... but it might work as
> written.
> 
> https://codereview.chromium.org/15792013/diff/1/net/net.gyp
> File net/net.gyp (right):
> 
> https://codereview.chromium.org/15792013/diff/1/net/net.gyp#newcode2468
> net/net.gyp:2468: '-Wno-deprecated-declarations',
> How about bracketing the offending lines with:
> 
> 
> #pragma GCC diagnostic push
> #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
>     g_type_init();
> #pragma GCC diagnostic pop
> 
> That, plus a comment, would make it clearer why we have this, and give us a
good
> chance of getting rid of the code some day.
> 
> It would also allow other deprecations to be illuminated (if they appear).
> 
> WDYT?  Would that work?
It works the way you proposed. I updated the patch accordingly. Thanks!

[yael.aharon1, 2013-06-03 16:54:02]

Can you please review the updated patch? thanks

[jar (doing other things), 2013-06-03 17:18:27]

lgtm

[commit-bot: I haz the power, 2013-06-03 17:20:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/15792013/6001

[commit-bot: I haz the power, 2013-06-04 06:46:13]

Change committed as 203873

[kinuko, 2013-06-04 07:02:55]

It looks using #pragma GCC inside functions makes compile fail on official
chrome build bot.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%...
../../net/tools/net_watcher/net_watcher.cc: In function 'int main(int, char**)':
../../net/tools/net_watcher/net_watcher.cc:139:error: #pragma GCC diagnostic not
allowed inside functions
../../net/tools/net_watcher/net_watcher.cc:140:error: #pragma GCC diagnostic not
allowed inside functions
../../net/tools/net_watcher/net_watcher.cc:142:error: #pragma GCC diagnostic not
allowed inside functions

[yael.aharon1, 2013-06-04 11:55:21]

On 2013/06/04 07:02:55, kinuko wrote:
> It looks using #pragma GCC inside functions makes compile fail on official
> chrome build bot.
> 
>
http://build.chromium.org/p/chromium.chrome/builders/Google%2520Chrome%2520Li...
> ../../net/tools/net_watcher/net_watcher.cc: In function 'int main(int,
char**)':
> ../../net/tools/net_watcher/net_watcher.cc:139:error: #pragma GCC diagnostic
not
> allowed inside functions
> ../../net/tools/net_watcher/net_watcher.cc:140:error: #pragma GCC diagnostic
not
> allowed inside functions
> ../../net/tools/net_watcher/net_watcher.cc:142:error: #pragma GCC diagnostic
not
> allowed inside functions

Sorry about that. I will move the #pragma out of the function.