Get net_watcher working on Gnome

Get net_watcher working on Gnome


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168565

[pauljensen, 2012-11-16 15:28:02]

Szymon, could you review this little change? Thanks!

[szym, 2012-11-16 15:29:37]

On 2012/11/16 15:28:02, pauljensen wrote:
> Szymon, could you review this little change? Thanks!

Does net_watcher fail to start on gnome? Or is it that ProxyConfigService is
unavailable and there are no signals from that source?

[pauljensen, 2012-11-16 16:25:16]

This is what happens without this change:

$ ./out/Debug/net_watcher 

(process:27992): GLib-GObject-CRITICAL **:
/build/buildd/glib2.0-2.32.3/./gobject/gtype.c:2722: You forgot to call
g_type_init()

(process:27992): GLib-CRITICAL **: g_once_init_leave: assertion `result != 0'
failed

(process:27992): GLib-GObject-CRITICAL **: g_object_new: assertion
`G_TYPE_IS_OBJECT (object_type)' failed

(process:27992): GLib-GObject-CRITICAL **:
/build/buildd/glib2.0-2.32.3/./gobject/gtype.c:2722: You forgot to call
g_type_init()

(process:27992): GLib-GObject-CRITICAL **: g_object_new: assertion
`G_TYPE_IS_OBJECT (object_type)' failed

(process:27992): GLib-GObject-CRITICAL **: g_object_ref: assertion `G_IS_OBJECT
(object)' failed
Segmentation fault (core dumped)

[szym, 2012-11-16 16:35:41]

lgtm

http://codereview.chromium.org/11308069/diff/1/net/tools/net_watcher/net_watc...
File net/tools/net_watcher/net_watcher.cc (right):

http://codereview.chromium.org/11308069/diff/1/net/tools/net_watcher/net_watc...
net/tools/net_watcher/net_watcher.cc:24: #if defined(OS_LINUX)
|| defined(OS_OPENBSD)
to match BrowserMainLoop::InitializeToolkit

http://codereview.chromium.org/11308069/diff/1/net/tools/net_watcher/net_watc...
net/tools/net_watcher/net_watcher.cc:126: #if defined(OS_LINUX)
ditto

http://codereview.chromium.org/11308069/diff/1/net/tools/net_watcher/net_watc...
net/tools/net_watcher/net_watcher.cc:129: g_type_init();
I am surprised ProxyConfigServiceLinuxTest does not actually interrogate gconf.

[pauljensen, 2012-11-16 16:49:32]

http://codereview.chromium.org/11308069/diff/1/net/tools/net_watcher/net_watc...
File net/tools/net_watcher/net_watcher.cc (right):

http://codereview.chromium.org/11308069/diff/1/net/tools/net_watcher/net_watc...
net/tools/net_watcher/net_watcher.cc:24: #if defined(OS_LINUX)
On 2012/11/16 16:35:41, szym wrote:
> || defined(OS_OPENBSD)
> to match BrowserMainLoop::InitializeToolkit

digit1 thought it wasn't worth it as it's guarding code that's just under
OS_LINUX:
http://codereview.chromium.org/10912132/diff/69015/net/tools/get_server_time/...
I figured it couldn't hurt, and if we ever make FreeBSD use
ProxyConfigServiceLinux we'll need to do this anyhow.

[szym, 2012-11-16 16:52:20]

Up to you.


On Fri, Nov 16, 2012 at 11:49 AM, <pauljensen@chromium.org> wrote:

>
> http://codereview.chromium.**org/11308069/diff/1/net/tools/**
>
net_watcher/net_watcher.cc<http://codereview.chromium.org/11308069/diff/1/net/tools/net_watcher/net_watcher.cc>
> File net/tools/net_watcher/net_**watcher.cc (right):
>
> http://codereview.chromium.**org/11308069/diff/1/net/tools/**
>
net_watcher/net_watcher.cc#**newcode24<http://codereview.chromium.org/11308069/diff/1/net/tools/net_watcher/net_watcher.cc#newcode24>
> net/tools/net_watcher/net_**watcher.cc:24: #if defined(OS_LINUX)
> On 2012/11/16 16:35:41, szym wrote:
>
>> || defined(OS_OPENBSD)
>> to match BrowserMainLoop::**InitializeToolkit
>>
>
> digit1 thought it wasn't worth it as it's guarding code that's just
> under OS_LINUX:
> http://codereview.chromium.**org/10912132/diff/69015/net/**
>
tools/get_server_time/get_**server_time.cc#newcode44<http://codereview.chromium.org/10912132/diff/69015/net/tools/get_server_time/get_server_time.cc#newcode44>
> I figured it couldn't hurt, and if we ever make FreeBSD use
> ProxyConfigServiceLinux we'll need to do this anyhow.
>
>
http://codereview.chromium.**org/11308069/<http://codereview.chromium.org/113...
>

[commit-bot: I haz the power, 2012-11-19 17:36:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pauljensen@chromium.org/11308069/5002

[commit-bot: I haz the power, 2012-11-19 19:22:17]

Change committed as 168565