chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java - Issue 1576493002: Change the Lo-Fi snackbar strings for Lo-Fi preview pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 1576493002: Change the Lo-Fi snackbar strings for Lo-Fi preview pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@showLoFiSnackbarNative

Patch Set: tbansal comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | chrome/android/java/strings/android_chrome_strings.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

index 93bcd93cea14d3f23e8e3539da8a3cda2e3873cb..1cda511c89fb04d00a945c86d57ddb58aaa18e5e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -2592,11 +2592,13 @@ public final class Tab implements ViewGroup.OnHierarchyChangeListener,

/**

* If a Lo-Fi snackbar has not been shown yet for this page load, a Lo-Fi snackbar is shown.

+ *

+ * @param isPreview Whether the Lo-Fi response was a preview response.

@CalledByNative

- public void onLoFiResponseReceived() {

+ public void onLoFiResponseReceived(boolean isPreview) {

if (mLoFiBarPopupController != null) {

- mLoFiBarPopupController.maybeCreateLoFiBar(this);

+ mLoFiBarPopupController.maybeCreateLoFiBar(this, isPreview);

}