Change the Lo-Fi snackbar strings for Lo-Fi preview pages

chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java

Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java
index 7b2c0035877ab2ac398231b49693eea2f3042672..a75a35a78e7884357ae80de39f0d75a6deab4c3e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java
@@ -54,15 +54,16 @@ public class LoFiBarPopupController implements SnackbarManager.SnackbarControlle
      * snackbar.
      *
      * @param tab The tab to show the snackbar on.
+     * @param isPreview Whether the snackbar should have the Lo-Fi preview message.
      */
-    public void maybeCreateLoFiBar(Tab tab) {
+    public void maybeCreateLoFiBar(Tab tab, final boolean isPreview) {
         if (mLoFiPopupShownForPageLoad) return;
         mLoFiPopupShownForPageLoad = true;
         if (tab.isHidden()) {
             TabObserver tabObserver = new EmptyTabObserver() {
                 @Override
                 public void onShown(Tab tab) {
-                    showLoFiBar(tab);
+                    showLoFiBar(tab, isPreview);
                     tab.removeObserver(this);
                 }
 
@@ -79,20 +80,30 @@ public class LoFiBarPopupController implements SnackbarManager.SnackbarControlle
             tab.addObserver(tabObserver);
             return;
         }
-        showLoFiBar(tab);
+        showLoFiBar(tab, isPreview);
     }
 
     /**
      * @param tab The tab. Saved to reload the page.
      */
-    private void showLoFiBar(Tab tab) {
+    private void showLoFiBar(Tab tab, boolean isPreview) {
         if (mDisabled) return;
         mTab = tab;

[newt (away), 2016/01/11 21:52:25]

I think this code would be easier to grasp if you created variables for the two
elements that vary -- the title and button text -- and deduplicate the shared
code, e.g.

    String message = mContext.getString(isPreview ? ...  : ...);
    String buttonText = ...
    mSnackbarManager.showSnackbar(
            Snackbar.make(message, this).setAction(buttonText, ...

[megjablon, 2016/01/11 22:54:57]

Done.

-        mSnackbarManager.showSnackbar(Snackbar.make(
-                mContext.getString(R.string.data_reduction_lo_fi_snackbar_message), this)
-                .setAction(mContext.getString(R.string.data_reduction_lo_fi_snackbar_action),
-                        tab.getId())
-                .setDuration(DEFAULT_LO_FI_SNACKBAR_SHOW_DURATION_MS));
+        if (isPreview) {
+            mSnackbarManager.showSnackbar(Snackbar.make(
+                    mContext.getString(R.string.data_reduction_lo_fi_preview_snackbar_message),
+                    this)
+                    .setAction(mContext
+                            .getString(R.string.data_reduction_lo_fi_preview_snackbar_action),
+                            tab.getId())
+                    .setDuration(DEFAULT_LO_FI_SNACKBAR_SHOW_DURATION_MS));
+        } else {
+            mSnackbarManager.showSnackbar(Snackbar.make(
+                    mContext.getString(R.string.data_reduction_lo_fi_snackbar_message), this)
+                    .setAction(mContext.getString(R.string.data_reduction_lo_fi_snackbar_action),
+                            tab.getId())
+                    .setDuration(DEFAULT_LO_FI_SNACKBAR_SHOW_DURATION_MS));
+        }
         DataReductionProxySettings.getInstance().incrementLoFiSnackbarShown();
         DataReductionProxyUma.dataReductionProxyLoFiUIAction(
                 DataReductionProxyUma.ACTION_LOAD_IMAGES_SNACKBAR_SHOWN);