Issue 15764010: Experimental functionize patch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15764010: Experimental functionize patch (Closed)

Created:
7 years, 6 months ago by rlarocque

Modified:
7 years, 6 months ago

Reviewers:

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Experimental functionize patch BUG=

Patch Set 1 #

Patch Set 2 : sync: Expose sync functionality as functions #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+885 lines, -845 lines)			Patch
M	sync/engine/commit.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	sync/engine/commit.cc	View		5 chunks	+12 lines, -4 lines	0 comments	Download
A	sync/engine/download.h	View	1	1 chunk	+59 lines, -0 lines	0 comments	Download
A	sync/engine/download.cc	View	1	1 chunk	+343 lines, -0 lines	0 comments	Download
A +	sync/engine/download_unittest.cc	View	1	5 chunks	+28 lines, -25 lines	0 comments	Download
D	sync/engine/download_updates_command.h	View		1 chunk	+0 lines, -63 lines	0 comments	Download
D	sync/engine/download_updates_command.cc	View		1 chunk	+0 lines, -224 lines	0 comments	Download
M	sync/engine/download_updates_command_unittest.cc	View	1	1 chunk	+0 lines, -93 lines	0 comments	Download
M	sync/engine/get_commit_ids_command.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	sync/engine/get_commit_ids_command.cc	View		6 chunks	+12 lines, -12 lines	0 comments	Download
M	sync/engine/sync_scheduler_impl.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	sync/engine/sync_scheduler_impl.cc	View	1	4 chunks	+20 lines, -10 lines	0 comments	Download
M	sync/engine/sync_scheduler_unittest.cc	View	1	37 chunks	+100 lines, -133 lines	0 comments	Download
M	sync/engine/syncer.h	View	1	3 chunks	+9 lines, -25 lines	0 comments	Download
M	sync/engine/syncer.cc	View	1	3 chunks	+106 lines, -142 lines	0 comments	Download
M	sync/engine/syncer_unittest.cc	View	1	10 chunks	+30 lines, -38 lines	0 comments	Download
M	sync/engine/syncer_util.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/sessions/data_type_tracker.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sync/sessions/data_type_tracker.cc	View	1	2 chunks	+18 lines, -0 lines	0 comments	Download
M	sync/sessions/nudge_tracker.h	View		2 chunks	+10 lines, -3 lines	0 comments	Download
M	sync/sessions/nudge_tracker.cc	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download
M	sync/sessions/nudge_tracker_unittest.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	sync/sessions/sync_session.h	View	1	3 chunks	+1 line, -14 lines	0 comments	Download
M	sync/sessions/sync_session.cc	View		1 chunk	+3 lines, -13 lines	0 comments	Download
M	sync/sessions/test_util.h	View		2 chunks	+40 lines, -10 lines	0 comments	Download
M	sync/sessions/test_util.cc	View	1	3 chunks	+59 lines, -30 lines	0 comments	Download
M	sync/sync_core.gypi	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sync/sync_tests.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download