Experimental functionize patch

sync/sessions/nudge_tracker.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A class to track the outstanding work required to bring the client back into
 // sync with the server.
 #ifndef SYNC_SESSIONS_NUDGE_TRACKER_H_
 #define SYNC_SESSIONS_NUDGE_TRACKER_H_
 
 #include <list>
@@ skipping 14 matching lines @@
 class SYNC_EXPORT_PRIVATE NudgeTracker {
  public:
   static size_t kDefaultMaxPayloadsPerType;
 
   NudgeTracker();
   ~NudgeTracker();
 
   // Returns true if there is a good reason for performing a sync cycle.
   // This does not take into account whether or not this is a good *time* to
   // perform a sync cycle; that's the scheduler's job.
-  bool IsSyncRequired();
+  bool IsSyncRequired() const;
 
   // Tells this class that all required update fetching and committing has
   // completed successfully.
   void RecordSuccessfulSyncCycle();
 
   // Takes note of a local change.
   void RecordLocalChange(ModelTypeSet types);
 
   // Takes note of a locally issued request to refresh a data type.
   void RecordLocalRefreshRequest(ModelTypeSet types);
@@ skipping 35 matching lines @@
   // Returns the 'source' of the GetUpdate request.
   //
   // This flag is deprecated, but still used by the server.  There can be more
   // than one reason to perform a particular sync cycle.  The GetUpdatesTrigger
   // message will contain more reliable information about the reasons for
   // performing a sync.
   //
   // See the implementation for important information about the coalesce logic.
   sync_pb::GetUpdatesCallerInfo::GetUpdatesSource updates_source() const;
 
-  // Fills a ProgressMarker for the next GetUpdates request.  This is used by
-  // the DownloadUpdatesCommand to dump lots of useful per-type state
+  // Fills a GetUpdatesTrigger message for the next GetUpdates request.  This is
+  // used by the DownloadUpdatesCommand to dump lots of useful per-type state
   // information into the GetUpdate request before sending it off to the server.
   void FillProtoMessage(
       ModelType type,
       sync_pb::GetUpdateTriggers* msg) const;
 
+  // Fills a ProgressMarker with single legacy notification hint expected by the
+  // sync server.  Newer servers will rely on the data set by FillProtoMessage()
+  // instead of this.
+  void SetLegacyNotificationHint(
+      ModelType type,
+      sync_pb::DataTypeProgressMarker* progress) const;
+
   // Adjusts the number of hints that can be stored locally.
   void SetHintBufferSize(size_t size);
 
  private:
   typedef std::map<ModelType, DataTypeTracker> TypeTrackerMap;
 
   TypeTrackerMap type_trackers_;
 
   // Merged updates source.  This should be obsolete, but the server still
   // relies on it for some heuristics.
@@ skipping 15 matching lines @@
 
   size_t num_payloads_per_type_;
 
   DISALLOW_COPY_AND_ASSIGN(NudgeTracker);
 };
 
 }  // namespace sessions
 }  // namespace syncer
 
 #endif  // SYNC_SESSIONS_NUDGE_TRACKER_H_