Issue 15763004: Replace tagged keys for fast access by smi, and use smi in boundscheck.

Issue 15763004: Replace tagged keys for fast access by smi, and use smi in boundscheck. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest

Modified:
7 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Replace tagged keys for fast access by smi, and use smi in boundscheck. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14794

Patch Set 2 : Remove HCheckSmiOrInt32 superseded by Representation::Smi #

Total comments: 2

Patch Set 3 : Removed comment #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -120 lines)			Patch
M	src/arm/lithium-arm.cc	View	1	3 chunks	+2 lines, -8 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		7 chunks	+7 lines, -7 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View	1 2	3 chunks	+3 lines, -5 lines	0 comments	Download
M	src/hydrogen.cc	View	1	2 chunks	+1 line, -13 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1	5 chunks	+3 lines, -37 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1	2 chunks	+8 lines, -18 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1	4 chunks	+3 lines, -9 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		8 chunks	+10 lines, -10 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1	4 chunks	+4 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM. https://chromiumcodereview.appspot.com/15763004/diff/7001/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://chromiumcodereview.appspot.com/15763004/diff/7001/src/code-stubs-hydrogen.cc#newcode591 src/code-stubs-hydrogen.cc:591: // Since we're forcing Integer32 representation for this ...

7 years, 7 months ago (2013-05-24 08:41:16 UTC) #2

Toon Verwaest

Addressed comments. Keeping the AddBoundsCheck for now.

7 years, 7 months ago (2013-05-24 08:51:35 UTC) #3

Toon Verwaest

7 years, 7 months ago (2013-05-24 08:52:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r14794 (presubmit successful).

Expand Messages | Collapse Messages