Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: src/ia32/lithium-ia32.h

Issue 15763004: Replace tagged keys for fast access by smi, and use smi in boundscheck. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Removed comment Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1578 matching lines...) Expand 10 before | Expand all | Expand 10 after
1589 } 1589 }
1590 }; 1590 };
1591 1591
1592 1592
1593 inline static bool ExternalArrayOpRequiresTemp( 1593 inline static bool ExternalArrayOpRequiresTemp(
1594 Representation key_representation, 1594 Representation key_representation,
1595 ElementsKind elements_kind) { 1595 ElementsKind elements_kind) {
1596 // Operations that require the key to be divided by two to be converted into 1596 // Operations that require the key to be divided by two to be converted into
1597 // an index cannot fold the scale operation into a load and need an extra 1597 // an index cannot fold the scale operation into a load and need an extra
1598 // temp register to do the work. 1598 // temp register to do the work.
1599 return key_representation.IsTagged() && 1599 return key_representation.IsSmi() &&
1600 (elements_kind == EXTERNAL_BYTE_ELEMENTS || 1600 (elements_kind == EXTERNAL_BYTE_ELEMENTS ||
1601 elements_kind == EXTERNAL_UNSIGNED_BYTE_ELEMENTS || 1601 elements_kind == EXTERNAL_UNSIGNED_BYTE_ELEMENTS ||
1602 elements_kind == EXTERNAL_PIXEL_ELEMENTS); 1602 elements_kind == EXTERNAL_PIXEL_ELEMENTS);
1603 } 1603 }
1604 1604
1605 1605
1606 class LLoadKeyedGeneric: public LTemplateInstruction<1, 3, 0> { 1606 class LLoadKeyedGeneric: public LTemplateInstruction<1, 3, 0> {
1607 public: 1607 public:
1608 LLoadKeyedGeneric(LOperand* context, LOperand* obj, LOperand* key) { 1608 LLoadKeyedGeneric(LOperand* context, LOperand* obj, LOperand* key) {
1609 inputs_[0] = context; 1609 inputs_[0] = context;
(...skipping 1377 matching lines...) Expand 10 before | Expand all | Expand 10 after
2987 2987
2988 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2988 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2989 }; 2989 };
2990 2990
2991 #undef DECLARE_HYDROGEN_ACCESSOR 2991 #undef DECLARE_HYDROGEN_ACCESSOR
2992 #undef DECLARE_CONCRETE_INSTRUCTION 2992 #undef DECLARE_CONCRETE_INSTRUCTION
2993 2993
2994 } } // namespace v8::internal 2994 } } // namespace v8::internal
2995 2995
2996 #endif // V8_IA32_LITHIUM_IA32_H_ 2996 #endif // V8_IA32_LITHIUM_IA32_H_
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698