Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 15735027: Use a direct include of utf_string_conversions.h in android_webview/, apps/, ash/, base/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Ilya Sherman, sadrul, jar (doing other things), derat+watch_chromium.org, ben+watch_chromium.org, tfarina, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, gavinp+memory_chromium.org, dcheng, asvitkine+watch_chromium.org, sail+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, android-webview-reviews_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of utf_string_conversions.h in android_webview/, apps/, ash/, base/. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -115 lines) Patch
M android_webview/browser/aw_form_database_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/state_serializer_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/shortcut_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/keyboard_overlay/keyboard_overlay_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/keyboard_overlay/keyboard_overlay_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/keyboard_overlay/keyboard_overlay_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/session_state_delegate_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/app_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/lock_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/panel_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/toplevel_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/widgets.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_type_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/brightness/tray_brightness.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/audio/tray_audio.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_icon.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_state_notifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_sms.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/power_status_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/settings/tray_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_display.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/date_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/tray_date.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/drive/tray_drive.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/ime/tray_ime.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/monitor/tray_monitor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/session_length_limit/tray_session_length_limit.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/status_area_widget_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/login_status.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_launcher_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_session_state_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_observer_hud.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/android/jni_string.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/android/jni_string_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/command_line.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/command_line_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M base/environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/guid_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/break_iterator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/case_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/char_iterator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/file_util_icu.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/file_util_icu_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/icu_string_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/icu_string_conversions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/number_formatting.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/i18n/number_formatting_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/rtl.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/rtl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/string_compare.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/string_search_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/time_formatting.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/time_formatting_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_value_serializer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/string_escape_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/logging.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/shared_memory_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/shared_memory_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/field_trial.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/metrics/stats_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/stats_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/native_library_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/native_library_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/native_library_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/platform_file_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/string16.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/string16_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/string_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/string_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/stringprintf.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_number_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_number_conversions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_piece_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_split.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_split_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/sys_string_conversions_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/sys_string_conversions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_file_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_shortcut_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/values.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/values_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/windows_version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
7 years, 6 months ago (2013-06-06 21:28:21 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 6 months ago (2013-06-07 16:13:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/15735027/1
7 years, 6 months ago (2013-06-07 16:23:05 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-07 18:37:09 UTC) #4
Message was sent while issue was closed.
Change committed as 204874

Powered by Google App Engine
This is Rietveld 408576698