Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: base/string16.cc

Issue 15735027: Use a direct include of utf_string_conversions.h in android_webview/, apps/, ash/, base/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/process_util_unittest.cc ('k') | base/string16_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/string16.h" 5 #include "base/string16.h"
6 6
7 #if defined(WCHAR_T_IS_UTF16) 7 #if defined(WCHAR_T_IS_UTF16)
8 8
9 #error This file should not be used on 2-byte wchar_t systems 9 #error This file should not be used on 2-byte wchar_t systems
10 // If this winds up being needed on 2-byte wchar_t systems, either the 10 // If this winds up being needed on 2-byte wchar_t systems, either the
11 // definitions below can be used, or the host system's wide character 11 // definitions below can be used, or the host system's wide character
12 // functions like wmemcmp can be wrapped. 12 // functions like wmemcmp can be wrapped.
13 13
14 #elif defined(WCHAR_T_IS_UTF32) 14 #elif defined(WCHAR_T_IS_UTF32)
15 15
16 #include <ostream> 16 #include <ostream>
17 17
18 #include "base/utf_string_conversions.h" 18 #include "base/strings/utf_string_conversions.h"
19 19
20 namespace base { 20 namespace base {
21 21
22 int c16memcmp(const char16* s1, const char16* s2, size_t n) { 22 int c16memcmp(const char16* s1, const char16* s2, size_t n) {
23 // We cannot call memcmp because that changes the semantics. 23 // We cannot call memcmp because that changes the semantics.
24 while (n-- > 0) { 24 while (n-- > 0) {
25 if (*s1 != *s2) { 25 if (*s1 != *s2) {
26 // We cannot use (*s1 - *s2) because char16 is unsigned. 26 // We cannot use (*s1 - *s2) because char16 is unsigned.
27 return ((*s1 < *s2) ? -1 : 1); 27 return ((*s1 < *s2) ? -1 : 1);
28 } 28 }
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 73
74 void PrintTo(const string16& str, std::ostream* out) { 74 void PrintTo(const string16& str, std::ostream* out) {
75 *out << str; 75 *out << str;
76 } 76 }
77 77
78 } // namespace base 78 } // namespace base
79 79
80 template class std::basic_string<char16, base::string16_char_traits>; 80 template class std::basic_string<char16, base::string16_char_traits>;
81 81
82 #endif // WCHAR_T_IS_UTF32 82 #endif // WCHAR_T_IS_UTF32
OLDNEW
« no previous file with comments | « base/process_util_unittest.cc ('k') | base/string16_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698