Make the browser->metro_viewer IPC channel name a constant instead of hardcoding it in a few places…

Make the browser<-->metro_viewer IPC channel name a constant instead of hardcoding it in a few places and passing it via a flag.

Supporting a more generic use case via flags was making things more complicated for no apparent reason (other than perhaps one day supporting a random-channel-id -- I removed that TODO in this CL). This simplification will make it easier to introduce some sort of --viewer-launch-via-appid-and-connect flag for https://codereview.chromium.org/16022003/

BUG=179830
TEST=Can still launch Ash in Metro.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207750

[gab, 2013-05-29 20:35:49]

Greg, please take a look (and Robert when you have a chance).

Cheers,
Gab

[gab, 2013-06-18 16:07:17]

Robert, throwing this your way since I intended you to be the reviewer, but
originally put greg since you were on vacation, but me and grt decided to simply
postpone this review since I was also going on vacation!

Cheers!
Gab

[robertshield, 2013-06-20 19:19:58]

lgtm

[commit-bot: I haz the power, 2013-06-20 19:20:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/15731003/16001

[commit-bot: I haz the power, 2013-06-20 19:31:01]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[gab, 2013-06-20 21:17:31]

+sky for OWNER on ash/ and chrome/

Feel free to CQ.

Thanks!
Gab

[sky, 2013-06-20 21:38:58]

LGTM with the following changes

https://codereview.chromium.org/15731003/diff/29002/ash/test/test_metro_viewe...
File ash/test/test_metro_viewer_process_host.h (right):

https://codereview.chromium.org/15731003/diff/29002/ash/test/test_metro_viewe...
ash/test/test_metro_viewer_process_host.h:18:
TestMetroViewerProcessHost(base::SingleThreadTaskRunner* ipc_task_runner);
explicit

https://codereview.chromium.org/15731003/diff/29002/chrome/browser/metro_view...
File chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h
(right):

https://codereview.chromium.org/15731003/diff/29002/chrome/browser/metro_view...
chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h:12:
explicit ChromeMetroViewerProcessHost();
nit: no explicit

[gab, 2013-06-20 21:52:39]

Ah, good catch, done!

Thanks,
Gab

https://codereview.chromium.org/15731003/diff/29002/ash/test/test_metro_viewe...
File ash/test/test_metro_viewer_process_host.h (right):

https://codereview.chromium.org/15731003/diff/29002/ash/test/test_metro_viewe...
ash/test/test_metro_viewer_process_host.h:18:
TestMetroViewerProcessHost(base::SingleThreadTaskRunner* ipc_task_runner);
On 2013/06/20 21:38:58, sky wrote:
> explicit

Done.

https://codereview.chromium.org/15731003/diff/29002/chrome/browser/metro_view...
File chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h
(right):

https://codereview.chromium.org/15731003/diff/29002/chrome/browser/metro_view...
chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h:12:
explicit ChromeMetroViewerProcessHost();
On 2013/06/20 21:38:58, sky wrote:
> nit: no explicit

Done.

[commit-bot: I haz the power, 2013-06-20 21:53:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/15731003/39001

[commit-bot: I haz the power, 2013-06-21 07:50:00]

Change committed as 207750