Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: win8/delegate_execute/command_execute_impl.cc

Issue 15731003: Make the browser->metro_viewer IPC channel name a constant instead of hardcoding it in a few places… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix explicits Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | win8/metro_driver/chrome_app_view_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: win8/delegate_execute/command_execute_impl.cc
diff --git a/win8/delegate_execute/command_execute_impl.cc b/win8/delegate_execute/command_execute_impl.cc
index 3d56344aea7b1810b3f4ab63b813e2a8470c1842..03fb4daa9ab73ae9ca56024031bf60d8d6aaacec 100644
--- a/win8/delegate_execute/command_execute_impl.cc
+++ b/win8/delegate_execute/command_execute_impl.cc
@@ -59,6 +59,7 @@ HRESULT GetUrlFromShellItem(IShellItem* shell_item, string16* url) {
return S_OK;
}
+#if defined(USE_AURA)
bool LaunchChromeBrowserProcess() {
base::FilePath delegate_exe_path;
if (!PathService::Get(base::FILE_EXE, &delegate_exe_path))
@@ -88,16 +89,15 @@ bool LaunchChromeBrowserProcess() {
// Prevent a Chrome window from showing up on the desktop.
cl.AppendSwitch(switches::kSilentLaunch);
- // Tell Chrome the IPC channel name to use.
- // TODO(robertshield): Figure out how to get this name to both the launched
- // desktop browser process and the resulting activated metro process.
- cl.AppendSwitchASCII(switches::kViewerConnection, "viewer");
+ // Tell Chrome to connect to the Metro viewer process.
+ cl.AppendSwitch(switches::kViewerConnect);
base::LaunchOptions launch_options;
launch_options.start_hidden = true;
return base::LaunchProcess(cl, launch_options, NULL);
}
+#endif // defined(USE_AURA)
} // namespace
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | win8/metro_driver/chrome_app_view_ash.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698