Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 15728006: Implement TouchFile on drive::FileSystem. (Closed)

Created:
7 years, 7 months ago by hidehiko
Modified:
7 years, 7 months ago
Reviewers:
hidehiko, kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Implement TouchFile on drive::FileSystem. This CL implements FileSystem::TouchFile for PPAPI. The method doesn't run yet in prod, because it is not accessed from FileSystemProxy. It'll be done in a following CL. BUG=144369 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -2 lines) Patch
M chrome/browser/chromeos/drive/file_system.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/drive_operations.h View 4 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/drive_operations.cc View 3 chunks +16 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/drive/file_system/touch_operation.h View 1 chunk +89 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/drive/file_system/touch_operation.cc View 1 chunk +122 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/drive/file_system/touch_operation_unittest.cc View 1 chunk +59 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 7 months ago (2013-05-23 06:20:50 UTC) #1
kinaba
lgtm, almost there!
7 years, 7 months ago (2013-05-23 06:37:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/15728006/1
7 years, 7 months ago (2013-05-23 14:34:29 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-23 19:37:36 UTC) #4
Message was sent while issue was closed.
Change committed as 201860

Powered by Google App Engine
This is Rietveld 408576698