Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3432)

Unified Diff: chrome/renderer/translate/translate_helper_metrics_unittest.cc

Issue 15728002: Translate: adopt html lang attribute if valid value is provided (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix WindowOpenClose crash Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/translate/translate_helper_metrics_unittest.cc
diff --git a/chrome/renderer/translate/translate_helper_metrics_unittest.cc b/chrome/renderer/translate/translate_helper_metrics_unittest.cc
index 50a0b30b343919809a6ccdb8d5b4777e7764121b..5a503ecda53955bf75334092b84ed79dbe9cb36f 100644
--- a/chrome/renderer/translate/translate_helper_metrics_unittest.cc
+++ b/chrome/renderer/translate/translate_helper_metrics_unittest.cc
@@ -33,23 +33,20 @@ class MetricsRecorder {
base_samples_ = histogram->SnapshotSamples();
}
- void CheckContentLanguage(int expected_not_provided,
- int expected_valid,
- int expected_invalid) {
- ASSERT_EQ(TranslateHelperMetrics::GetMetricsName(
- TranslateHelperMetrics::UMA_CONTENT_LANGUAGE), key_);
+ void CheckLanguage(TranslateHelperMetrics::MetricsNameIndex index,
+ int expected_not_provided,
+ int expected_valid,
+ int expected_invalid) {
+ ASSERT_EQ(TranslateHelperMetrics::GetMetricsName(index), key_);
Snapshot();
- EXPECT_EQ(
- expected_not_provided,
- GetCount(TranslateHelperMetrics::CONTENT_LANGUAGE_NOT_PROVIDED));
- EXPECT_EQ(
- expected_valid,
- GetCount(TranslateHelperMetrics::CONTENT_LANGUAGE_VALID));
- EXPECT_EQ(
- expected_invalid,
- GetCount(TranslateHelperMetrics::CONTENT_LANGUAGE_INVALID));
+ EXPECT_EQ(expected_not_provided,
+ GetCount(TranslateHelperMetrics::LANGUAGE_NOT_PROVIDED));
+ EXPECT_EQ(expected_valid,
+ GetCount(TranslateHelperMetrics::LANGUAGE_VALID));
+ EXPECT_EQ(expected_invalid,
+ GetCount(TranslateHelperMetrics::LANGUAGE_INVALID));
}
void CheckLanguageVerification(int expected_cld_disabled,
@@ -150,13 +147,26 @@ TEST(TranslateHelperMetricsTest, ReportContentLanguage) {
MetricsRecorder recorder(TranslateHelperMetrics::GetMetricsName(
TranslateHelperMetrics::UMA_CONTENT_LANGUAGE));
- recorder.CheckContentLanguage(0, 0, 0);
+ recorder.CheckLanguage(TranslateHelperMetrics::UMA_CONTENT_LANGUAGE, 0, 0, 0);
TranslateHelperMetrics::ReportContentLanguage(std::string(), std::string());
- recorder.CheckContentLanguage(1, 0, 0);
+ recorder.CheckLanguage(TranslateHelperMetrics::UMA_CONTENT_LANGUAGE, 1, 0, 0);
TranslateHelperMetrics::ReportContentLanguage("ja_JP", "ja-JP");
- recorder.CheckContentLanguage(1, 0, 1);
+ recorder.CheckLanguage(TranslateHelperMetrics::UMA_CONTENT_LANGUAGE, 1, 0, 1);
TranslateHelperMetrics::ReportContentLanguage("en", "en");
- recorder.CheckContentLanguage(1, 1, 1);
+ recorder.CheckLanguage(TranslateHelperMetrics::UMA_CONTENT_LANGUAGE, 1, 1, 1);
+}
+
+TEST(TranslateHelperMetricsTest, ReportHtmlLang) {
+ MetricsRecorder recorder(TranslateHelperMetrics::GetMetricsName(
+ TranslateHelperMetrics::UMA_HTML_LANG));
+
+ recorder.CheckLanguage(TranslateHelperMetrics::UMA_HTML_LANG, 0, 0, 0);
+ TranslateHelperMetrics::ReportHtmlLang(std::string(), std::string());
+ recorder.CheckLanguage(TranslateHelperMetrics::UMA_HTML_LANG, 1, 0, 0);
+ TranslateHelperMetrics::ReportHtmlLang("ja_JP", "ja-JP");
+ recorder.CheckLanguage(TranslateHelperMetrics::UMA_HTML_LANG, 1, 0, 1);
+ TranslateHelperMetrics::ReportHtmlLang("en", "en");
+ recorder.CheckLanguage(TranslateHelperMetrics::UMA_HTML_LANG, 1, 1, 1);
}
TEST(TranslateHelperMetricsTest, ReportLanguageVerification) {
« no previous file with comments | « chrome/renderer/translate/translate_helper_metrics.cc ('k') | chrome/renderer/translate/translate_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698