Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Side by Side Diff: chrome/renderer/translate/translate_helper_metrics_unittest.cc

Issue 15728002: Translate: adopt html lang attribute if valid value is provided (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix WindowOpenClose crash Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/translate/translate_helper_metrics.h" 5 #include "chrome/renderer/translate/translate_helper_metrics.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/metrics/histogram.h" 9 #include "base/metrics/histogram.h"
10 #include "base/metrics/histogram_samples.h" 10 #include "base/metrics/histogram_samples.h"
(...skipping 15 matching lines...) Expand all
26 : key_(key), 26 : key_(key),
27 base_samples_(NULL), 27 base_samples_(NULL),
28 samples_(NULL) { 28 samples_(NULL) {
29 StatisticsRecorder::Initialize(); 29 StatisticsRecorder::Initialize();
30 30
31 HistogramBase* histogram = StatisticsRecorder::FindHistogram(key_); 31 HistogramBase* histogram = StatisticsRecorder::FindHistogram(key_);
32 if (histogram) 32 if (histogram)
33 base_samples_ = histogram->SnapshotSamples(); 33 base_samples_ = histogram->SnapshotSamples();
34 } 34 }
35 35
36 void CheckContentLanguage(int expected_not_provided, 36 void CheckLanguage(TranslateHelperMetrics::MetricsNameIndex index,
37 int expected_valid, 37 int expected_not_provided,
38 int expected_invalid) { 38 int expected_valid,
39 ASSERT_EQ(TranslateHelperMetrics::GetMetricsName( 39 int expected_invalid) {
40 TranslateHelperMetrics::UMA_CONTENT_LANGUAGE), key_); 40 ASSERT_EQ(TranslateHelperMetrics::GetMetricsName(index), key_);
41 41
42 Snapshot(); 42 Snapshot();
43 43
44 EXPECT_EQ( 44 EXPECT_EQ(expected_not_provided,
45 expected_not_provided, 45 GetCount(TranslateHelperMetrics::LANGUAGE_NOT_PROVIDED));
46 GetCount(TranslateHelperMetrics::CONTENT_LANGUAGE_NOT_PROVIDED)); 46 EXPECT_EQ(expected_valid,
47 EXPECT_EQ( 47 GetCount(TranslateHelperMetrics::LANGUAGE_VALID));
48 expected_valid, 48 EXPECT_EQ(expected_invalid,
49 GetCount(TranslateHelperMetrics::CONTENT_LANGUAGE_VALID)); 49 GetCount(TranslateHelperMetrics::LANGUAGE_INVALID));
50 EXPECT_EQ(
51 expected_invalid,
52 GetCount(TranslateHelperMetrics::CONTENT_LANGUAGE_INVALID));
53 } 50 }
54 51
55 void CheckLanguageVerification(int expected_cld_disabled, 52 void CheckLanguageVerification(int expected_cld_disabled,
56 int expected_cld_only, 53 int expected_cld_only,
57 int expected_unknown, 54 int expected_unknown,
58 int expected_cld_agree, 55 int expected_cld_agree,
59 int expected_cld_disagree) { 56 int expected_cld_disagree) {
60 ASSERT_EQ(TranslateHelperMetrics::GetMetricsName( 57 ASSERT_EQ(TranslateHelperMetrics::GetMetricsName(
61 TranslateHelperMetrics::UMA_LANGUAGE_VERIFICATION), key_); 58 TranslateHelperMetrics::UMA_LANGUAGE_VERIFICATION), key_);
62 59
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 140
144 DISALLOW_COPY_AND_ASSIGN(MetricsRecorder); 141 DISALLOW_COPY_AND_ASSIGN(MetricsRecorder);
145 }; 142 };
146 143
147 } // namespace 144 } // namespace
148 145
149 TEST(TranslateHelperMetricsTest, ReportContentLanguage) { 146 TEST(TranslateHelperMetricsTest, ReportContentLanguage) {
150 MetricsRecorder recorder(TranslateHelperMetrics::GetMetricsName( 147 MetricsRecorder recorder(TranslateHelperMetrics::GetMetricsName(
151 TranslateHelperMetrics::UMA_CONTENT_LANGUAGE)); 148 TranslateHelperMetrics::UMA_CONTENT_LANGUAGE));
152 149
153 recorder.CheckContentLanguage(0, 0, 0); 150 recorder.CheckLanguage(TranslateHelperMetrics::UMA_CONTENT_LANGUAGE, 0, 0, 0);
154 TranslateHelperMetrics::ReportContentLanguage(std::string(), std::string()); 151 TranslateHelperMetrics::ReportContentLanguage(std::string(), std::string());
155 recorder.CheckContentLanguage(1, 0, 0); 152 recorder.CheckLanguage(TranslateHelperMetrics::UMA_CONTENT_LANGUAGE, 1, 0, 0);
156 TranslateHelperMetrics::ReportContentLanguage("ja_JP", "ja-JP"); 153 TranslateHelperMetrics::ReportContentLanguage("ja_JP", "ja-JP");
157 recorder.CheckContentLanguage(1, 0, 1); 154 recorder.CheckLanguage(TranslateHelperMetrics::UMA_CONTENT_LANGUAGE, 1, 0, 1);
158 TranslateHelperMetrics::ReportContentLanguage("en", "en"); 155 TranslateHelperMetrics::ReportContentLanguage("en", "en");
159 recorder.CheckContentLanguage(1, 1, 1); 156 recorder.CheckLanguage(TranslateHelperMetrics::UMA_CONTENT_LANGUAGE, 1, 1, 1);
157 }
158
159 TEST(TranslateHelperMetricsTest, ReportHtmlLang) {
160 MetricsRecorder recorder(TranslateHelperMetrics::GetMetricsName(
161 TranslateHelperMetrics::UMA_HTML_LANG));
162
163 recorder.CheckLanguage(TranslateHelperMetrics::UMA_HTML_LANG, 0, 0, 0);
164 TranslateHelperMetrics::ReportHtmlLang(std::string(), std::string());
165 recorder.CheckLanguage(TranslateHelperMetrics::UMA_HTML_LANG, 1, 0, 0);
166 TranslateHelperMetrics::ReportHtmlLang("ja_JP", "ja-JP");
167 recorder.CheckLanguage(TranslateHelperMetrics::UMA_HTML_LANG, 1, 0, 1);
168 TranslateHelperMetrics::ReportHtmlLang("en", "en");
169 recorder.CheckLanguage(TranslateHelperMetrics::UMA_HTML_LANG, 1, 1, 1);
160 } 170 }
161 171
162 TEST(TranslateHelperMetricsTest, ReportLanguageVerification) { 172 TEST(TranslateHelperMetricsTest, ReportLanguageVerification) {
163 MetricsRecorder recorder(TranslateHelperMetrics::GetMetricsName( 173 MetricsRecorder recorder(TranslateHelperMetrics::GetMetricsName(
164 TranslateHelperMetrics::UMA_LANGUAGE_VERIFICATION)); 174 TranslateHelperMetrics::UMA_LANGUAGE_VERIFICATION));
165 175
166 recorder.CheckLanguageVerification(0, 0, 0, 0, 0); 176 recorder.CheckLanguageVerification(0, 0, 0, 0, 0);
167 TranslateHelperMetrics::ReportLanguageVerification( 177 TranslateHelperMetrics::ReportLanguageVerification(
168 TranslateHelperMetrics::LANGUAGE_VERIFICATION_CLD_DISABLED); 178 TranslateHelperMetrics::LANGUAGE_VERIFICATION_CLD_DISABLED);
169 recorder.CheckLanguageVerification(1, 0, 0, 0, 0); 179 recorder.CheckLanguageVerification(1, 0, 0, 0, 0);
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 TranslateHelperMetrics::UMA_LANGUAGE_DETECTION)); 248 TranslateHelperMetrics::UMA_LANGUAGE_DETECTION));
239 recorder.CheckTotalCount(0); 249 recorder.CheckTotalCount(0);
240 TimeTicks begin = TimeTicks::Now(); 250 TimeTicks begin = TimeTicks::Now();
241 TimeTicks end = begin + base::TimeDelta::FromMicroseconds(9009); 251 TimeTicks end = begin + base::TimeDelta::FromMicroseconds(9009);
242 TranslateHelperMetrics::ReportLanguageDetectionTime(begin, end); 252 TranslateHelperMetrics::ReportLanguageDetectionTime(begin, end);
243 recorder.CheckValueInLogs(9.009); 253 recorder.CheckValueInLogs(9.009);
244 recorder.CheckTotalCount(1); 254 recorder.CheckTotalCount(1);
245 } 255 }
246 256
247 #endif // defined(ENABLE_LANGUAGE_DETECTION) 257 #endif // defined(ENABLE_LANGUAGE_DETECTION)
OLDNEW
« no previous file with comments | « chrome/renderer/translate/translate_helper_metrics.cc ('k') | chrome/renderer/translate/translate_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698