Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Unified Diff: pkg/analyzer/test/generated/source_factory_test.dart

Issue 1572073003: Don't log stack trace for a bad package URL in a source file. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/generated/source_factory_test.dart
diff --git a/pkg/analyzer/test/generated/source_factory_test.dart b/pkg/analyzer/test/generated/source_factory_test.dart
index e9dfd9453d7cb9de641d6bf6ae7edbb26f4445d5..9932cf8a0596870b306e66705b583d79d420a56f 100644
--- a/pkg/analyzer/test/generated/source_factory_test.dart
+++ b/pkg/analyzer/test/generated/source_factory_test.dart
@@ -9,6 +9,7 @@ import 'dart:convert';
import 'package:analyzer/file_system/file_system.dart';
import 'package:analyzer/file_system/memory_file_system.dart';
import 'package:analyzer/source/package_map_resolver.dart';
+import 'package:analyzer/src/generated/engine.dart' show AnalysisEngine, Logger;
import 'package:analyzer/src/generated/java_core.dart';
import 'package:analyzer/src/generated/java_engine_io.dart';
import 'package:analyzer/src/generated/java_io.dart';
@@ -64,8 +65,17 @@ void runPackageMapTests() {
resolvers.add(customResolver);
}
SourceFactory factory = new SourceFactory(resolvers, packages);
- Source source = factory.resolveUri(containingSource, uri);
- return source != null ? source.fullName : null;
+
+ expect(AnalysisEngine.instance.logger, Logger.NULL);
+ var logger = new TestLogger();
+ AnalysisEngine.instance.logger = logger;
+ try {
+ Source source = factory.resolveUri(containingSource, uri);
+ expect(logger.log, []);
+ return source != null ? source.fullName : null;
+ } finally {
+ AnalysisEngine.instance.logger = Logger.NULL;
+ }
}
Uri restorePackageUri(
@@ -122,6 +132,10 @@ quiver:/home/somebody/.pub/cache/quiver-1.2.1/lib
customResolver: testResolver);
expect(uri, testResolver.uriPath);
});
+ test('Bad package URI', () {
+ String uri = resolvePackageUri(config: '', uri: 'package:foo');
+ expect(uri, isNull);
+ });
test('Invalid URI', () {
// TODO(pquitslund): fix clients to handle errors appropriately
// CLI: print message 'invalid package file format'

Powered by Google App Engine
This is Rietveld 408576698