Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: pkg/analyzer/test/generated/test_support.dart

Issue 1572073003: Don't log stack trace for a bad package URL in a source file. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/generated/test_support.dart
diff --git a/pkg/analyzer/test/generated/test_support.dart b/pkg/analyzer/test/generated/test_support.dart
index 9db703b066313683ff8c8536c123beb3b3c367ef..87b12820626feaaeb9c2df6ba4a37e91e0e3fa05 100644
--- a/pkg/analyzer/test/generated/test_support.dart
+++ b/pkg/analyzer/test/generated/test_support.dart
@@ -423,9 +423,9 @@ class GatheringErrorListener implements AnalysisErrorListener {
*/
bool _equalErrors(AnalysisError firstError, AnalysisError secondError) =>
identical(firstError.errorCode, secondError.errorCode) &&
- firstError.offset == secondError.offset &&
- firstError.length == secondError.length &&
- _equalSources(firstError.source, secondError.source);
+ firstError.offset == secondError.offset &&
+ firstError.length == secondError.length &&
+ _equalSources(firstError.source, secondError.source);
/**
* Return `true` if the two sources are equivalent.
@@ -537,23 +537,18 @@ class GatheringErrorListener implements AnalysisErrorListener {
*/
class TestLogger implements Logger {
/**
- * The number of error messages that were logged.
+ * All logged messages.
*/
- int errorCount = 0;
-
- /**
- * The number of informational messages that were logged.
- */
- int infoCount = 0;
+ List<String> log = [];
@override
void logError(String message, [CaughtException exception]) {
- errorCount++;
+ log.add("error: $message");
}
@override
void logInformation(String message, [CaughtException exception]) {
- infoCount++;
+ log.add("info: $message");
}
}

Powered by Google App Engine
This is Rietveld 408576698