Make sure that the UI window created by base::MessagePumpForUI is destoyed on the same thread (Wind…

base/message_pump.h

Index: base/message_pump.h
diff --git a/base/message_pump.h b/base/message_pump.h
index b2e0a425656c6962f7d960d3637e68eab48cab36..138ad44f6e397ba9a567b6ad8a30969ade788df1 100644
--- a/base/message_pump.h
+++ b/base/message_pump.h
@@ -119,6 +119,11 @@ class BASE_EXPORT MessagePump : public RefCountedThreadSafe<MessagePump> {
   // used on the thread that called Run.
   virtual void ScheduleDelayedWork(const TimeTicks& delayed_work_time) = 0;
 
+  // Stops the pump and frees any resources that must to be freed on the thread
+  // that called Run(). This method should be called on the same thread that
+  // called Run().
+  virtual void Stop() = 0;

[darin (slow to review), 2013/06/18 18:28:42]

It is perhaps confusing to have a method named Quit and a method named Stop on
the same interface.  They sound like synonyms for the same thing.

"Shutdown" might be a better name since it better conveys a notion of finality.

Also, the comment says that this should be called on the same thread that called
Run.  However, from reading MessagePumpWin, it looks like InitMessageWnd is
called from the constructor, so maybe you should say that Shutdown must be
called on the same thread that allocated the pump.

I think the important thing to document here is that this is potentially the
last chance for the MessagePump to do work on the thread where it was
constructed.

[alexeypa (please no reviews), 2013/06/18 19:44:23]

Done.
It is already in the comment.
What is important is that Shutdown() is called on the same thread as Run() was
called. The fact that the pump is also created on this thread is not part of
MessagePump interface and can be changed in the future.
Done.

+
  protected:
   virtual ~MessagePump();
   friend class RefCountedThreadSafe<MessagePump>;