Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: base/message_loop.cc

Issue 15709015: Make sure that the UI window created by base::MessagePumpForUI is destoyed on the same thread (Wind… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR feedback. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/message_pump.h » ('j') | base/message_pump.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop.cc
diff --git a/base/message_loop.cc b/base/message_loop.cc
index 0d8a8ef0d769875f386e244b69932779e9ed2271..c8b2ecb49261d6159a271a8fdcb8aa43d54f9467 100644
--- a/base/message_loop.cc
+++ b/base/message_loop.cc
@@ -221,6 +221,9 @@ MessageLoop::~MessageLoop() {
WillDestroyCurrentMessageLoop();
message_loop_proxy_ = NULL;
+ // Stop the message pump and free any thread-bound resources.
+ pump_->Stop();
+
// OK, now make it so that no one can find us.
lazy_tls_ptr.Pointer()->Set(NULL);
« no previous file with comments | « no previous file | base/message_pump.h » ('j') | base/message_pump.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698