Issue 15697018: Fix style errors in PopupContainer and PopupListBox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15697018: Fix style errors in PopupContainer and PopupListBox. (Closed)

Created:
7 years, 7 months ago by tkent

Modified:
7 years, 7 months ago

Reviewers:
Hajime Morrita, tkent

CC:
blink-reviews, eae+blinkwatch, jeez

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix style errors in PopupContainer and PopupListBox. This is a preparation to move these files out of core/platform. - Fix coding style erros - Wrap long comments - Remove unnecessary virtual from PopupContainer::isInterestedInEventForKey - Add OVERRIDEs - Move constant values in PopupListBox.h to PopupListBox.cpp BUG=242763 TEST=none; just a refactoring. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150950

Patch Set 1 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+141 lines, -134 lines)			Patch
M	Source/core/platform/chromium/PopupContainer.h	View	2 chunks	+22 lines, -18 lines	0 comments	Download
M	Source/core/platform/chromium/PopupContainer.cpp	View	17 chunks	+44 lines, -49 lines	0 comments	Download
M	Source/core/platform/chromium/PopupListBox.h	View	8 chunks	+27 lines, -32 lines	0 comments	Download
M	Source/core/platform/chromium/PopupListBox.cpp	View	15 chunks	+48 lines, -35 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/15697018/4001

7 years, 7 months ago (2013-05-23 03:24:18 UTC) #3

Message was sent while issue was closed.

Change committed as 150950

Expand Messages | Collapse Messages