Autofill:requestAutocomplete: Enable prompting for complete address when instrument being used does…

Autofill:requestAutocomplete: Enable prompting for complete address when instrument being used doesn't have full address.

Resubmitting r201451 which is rolled back because of static initilizers in wallet_address.cc

BUG=173517
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201907

[Raman Kakilate, 2013-05-22 17:56:50]

Ilya PTAL. Earlier CL was rolled back because of static initializers in
wallet_address.cc.

[Raman Kakilate, 2013-05-22 20:57:46]

+estade, PTAL.

[Evan Stade, 2013-05-22 21:42:57]

https://codereview.chromium.org/15697010/diff/8001/components/autofill/browse...
File components/autofill/browser/wallet/wallet_address.cc (right):

https://codereview.chromium.org/15697010/diff/8001/components/autofill/browse...
components/autofill/browser/wallet/wallet_address.cc:17: const string16
kFullAddress = ASCIIToUTF16("FULL");
instead of removing these, you can make them char[]

see for example:

const char kAddNewItemKey[] = "add-new-item";

https://codereview.chromium.org/15697010/diff/11001/components/autofill/brows...
File components/autofill/browser/wallet/wallet_address.cc (right):

https://codereview.chromium.org/15697010/diff/11001/components/autofill/brows...
components/autofill/browser/wallet/wallet_address.cc:70: string16
is_minimal_address;
this should be a std::string (because it can only hold ASCII values)

https://codereview.chromium.org/15697010/diff/11001/components/autofill/brows...
components/autofill/browser/wallet/wallet_address.cc:186: string16
address_state;
this as well should be std::string

[Raman Kakilate, 2013-05-22 22:15:25]

https://codereview.chromium.org/15697010/diff/8001/components/autofill/browse...
File components/autofill/browser/wallet/wallet_address.cc (right):

https://codereview.chromium.org/15697010/diff/8001/components/autofill/browse...
components/autofill/browser/wallet/wallet_address.cc:17: const string16
kFullAddress = ASCIIToUTF16("FULL");
On 2013/05/22 21:42:57, Evan Stade wrote:
> instead of removing these, you can make them char[]
> 
> see for example:
> 
> const char kAddNewItemKey[] = "add-new-item";

Done.

https://codereview.chromium.org/15697010/diff/11001/components/autofill/brows...
File components/autofill/browser/wallet/wallet_address.cc (right):

https://codereview.chromium.org/15697010/diff/11001/components/autofill/brows...
components/autofill/browser/wallet/wallet_address.cc:70: string16
is_minimal_address;
On 2013/05/22 21:42:57, Evan Stade wrote:
> this should be a std::string (because it can only hold ASCII values)

Done.

https://codereview.chromium.org/15697010/diff/11001/components/autofill/brows...
components/autofill/browser/wallet/wallet_address.cc:186: string16
address_state;
On 2013/05/22 21:42:57, Evan Stade wrote:
> this as well should be std::string

Done.

[Evan Stade, 2013-05-22 22:54:25]

changes compared to r201451 lgtm

https://codereview.chromium.org/15697010/diff/12002/components/autofill/brows...
File components/autofill/browser/wallet/wallet_address.cc (right):

https://codereview.chromium.org/15697010/diff/12002/components/autofill/brows...
components/autofill/browser/wallet/wallet_address.cc:17: const char
kFullAddress[] = "FULL";
docs please

[Raman Kakilate, 2013-05-22 23:24:07]

https://codereview.chromium.org/15697010/diff/12002/components/autofill/brows...
File components/autofill/browser/wallet/wallet_address.cc (right):

https://codereview.chromium.org/15697010/diff/12002/components/autofill/brows...
components/autofill/browser/wallet/wallet_address.cc:17: const char
kFullAddress[] = "FULL";
On 2013/05/22 22:54:25, Evan Stade wrote:
> docs please

Done.

[commit-bot: I haz the power, 2013-05-22 23:25:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ramankk@chromium.org/15697010/5002

[commit-bot: I haz the power, 2013-05-23 05:37:29]

Failed to apply patch for components/autofill/browser/wallet/wallet_items.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file components/autofill/browser/wallet/wallet_items.h
  Hunk #1 FAILED at 108.
  1 out of 1 hunk FAILED -- saving rejects to file
components/autofill/browser/wallet/wallet_items.h.rej

Patch:       components/autofill/browser/wallet/wallet_items.h
Index: components/autofill/browser/wallet/wallet_items.h
diff --git a/components/autofill/browser/wallet/wallet_items.h
b/components/autofill/browser/wallet/wallet_items.h
index
14c45216fd81bf8af444ee4ebc690e0245c9a146..215c41d46c6adaeec238f61a2d26e11117f3ab1e
100644
--- a/components/autofill/browser/wallet/wallet_items.h
+++ b/components/autofill/browser/wallet/wallet_items.h
@@ -108,8 +108,8 @@ class WalletItems {
 
    private:
     friend class WalletItemsTest;
-    friend scoped_ptr<MaskedInstrument> GetTestMaskedInstrumentWithId(
-        const std::string&);
+    friend scoped_ptr<MaskedInstrument>
GetTestMaskedInstrumentWithIdAndAddress(
+        const std::string&, scoped_ptr<Address> address);
     FRIEND_TEST_ALL_PREFIXES(::autofill::WalletInstrumentWrapperTest,
                              GetInfoCreditCardExpMonth);
     FRIEND_TEST_ALL_PREFIXES(::autofill::WalletInstrumentWrapperTest,

[commit-bot: I haz the power, 2013-05-23 07:01:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ramankk@chromium.org/15697010/31001

[commit-bot: I haz the power, 2013-05-23 07:01:11]

Failed to apply patch for components/autofill/browser/wallet/wallet_items.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file components/autofill/browser/wallet/wallet_items.h
  Hunk #1 FAILED at 108.
  1 out of 1 hunk FAILED -- saving rejects to file
components/autofill/browser/wallet/wallet_items.h.rej

Patch:       components/autofill/browser/wallet/wallet_items.h
Index: components/autofill/browser/wallet/wallet_items.h
diff --git a/components/autofill/browser/wallet/wallet_items.h
b/components/autofill/browser/wallet/wallet_items.h
index
14c45216fd81bf8af444ee4ebc690e0245c9a146..215c41d46c6adaeec238f61a2d26e11117f3ab1e
100644
--- a/components/autofill/browser/wallet/wallet_items.h
+++ b/components/autofill/browser/wallet/wallet_items.h
@@ -108,8 +108,8 @@ class WalletItems {
 
    private:
     friend class WalletItemsTest;
-    friend scoped_ptr<MaskedInstrument> GetTestMaskedInstrumentWithId(
-        const std::string&);
+    friend scoped_ptr<MaskedInstrument>
GetTestMaskedInstrumentWithIdAndAddress(
+        const std::string&, scoped_ptr<Address> address);
     FRIEND_TEST_ALL_PREFIXES(::autofill::WalletInstrumentWrapperTest,
                              GetInfoCreditCardExpMonth);
     FRIEND_TEST_ALL_PREFIXES(::autofill::WalletInstrumentWrapperTest,

[commit-bot: I haz the power, 2013-05-23 16:07:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ramankk@chromium.org/15697010/35001

[commit-bot: I haz the power, 2013-05-23 22:34:22]

Change committed as 201907