src/hydrogen-instructions.h - Issue 15691017: Make assertion scopes thread safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.h

Issue 15691017: Make assertion scopes thread safe. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-instructions.h

diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h

index 9f52569ccf60fa1a03a7a6aafc178f991a22b6d6..cd5b271206e9ddf48f821361ed7824389c899576 100644

--- a/src/hydrogen-instructions.h

+++ b/src/hydrogen-instructions.h

@@ -3153,7 +3153,7 @@ class HConstant: public HTemplateInstruction<0> {

// to be tenured so that it's guaranteed not be be located in new space.

handle_ = FACTORY->NewNumber(double_value_, TENURED);

}

- ALLOW_HANDLE_DEREF(Isolate::Current(), "smi check");

+ AllowDeferredHandleDereference smi_check;

ASSERT(has_int32_value_ || !handle_->IsSmi());

return handle_;

}