src/hydrogen-gvn.cc - Issue 15691017: Make assertion scopes thread safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-gvn.cc

Issue 15691017: Make assertion scopes thread safe. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-gvn.cc

diff --git a/src/hydrogen-gvn.cc b/src/hydrogen-gvn.cc

index 5a9af5eb6c446a95a577ba2583de82ab9e4d3ee1..aa2dff765563977211ad473dd73b830a6ff5390b 100644

--- a/src/hydrogen-gvn.cc

+++ b/src/hydrogen-gvn.cc

@@ -368,10 +368,7 @@ HGlobalValueNumberer::HGlobalValueNumberer(HGraph* graph, CompilationInfo* info)

block_side_effects_(graph->blocks()->length(), graph->zone()),

loop_side_effects_(graph->blocks()->length(), graph->zone()),

visited_on_paths_(graph->zone(), graph->blocks()->length()) {

-#ifdef DEBUG

- ASSERT(info->isolate()->optimizing_compiler_thread()->IsOptimizerThread() ||

- !info->isolate()->heap()->IsAllocationAllowed());

-#endif

+ ASSERT(!AllowHandleAllocation::IsAllowed());

block_side_effects_.AddBlock(GVNFlagSet(), graph_->blocks()->length(),

graph_->zone());

loop_side_effects_.AddBlock(GVNFlagSet(), graph_->blocks()->length(),