Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 15691007: Make Object.freeze fast (Closed)

Created:
7 years, 7 months ago by adamk
Modified:
7 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Make Object.freeze fast This patch both speeds up the freeze operation itself, but also allows properties to remain in fast mode. Objects with non-empty elements backing stores still end up with slow elements. Relanding r14758 and r14759 with fix for Test262: only mark properties and elements READ_ONLY if they are not JS setter/getters. Tightened up tests to assert frozen-ness, and added targeted tests for the new code (covering accessors). BUG=v8:1858, 115960 R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+414 lines, -82 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/heap.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/objects.h View 6 chunks +19 lines, -5 lines 0 comments Download
M src/objects.cc View 15 chunks +223 lines, -62 lines 0 comments Download
M src/objects-inl.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/property-details.h View 3 chunks +9 lines, -1 line 0 comments Download
M src/runtime.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/runtime.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/v8natives.js View 1 chunk +19 lines, -12 lines 0 comments Download
M test/mjsunit/object-freeze.js View 2 chunks +105 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
7 years, 7 months ago (2013-05-22 22:42:31 UTC) #1
Toon Verwaest
lgtm
7 years, 7 months ago (2013-05-23 06:43:38 UTC) #2
Toon Verwaest
Committed patchset #1 manually as r14762 (presubmit successful).
7 years, 7 months ago (2013-05-23 07:06:08 UTC) #3
Toon Verwaest
7 years, 7 months ago (2013-05-23 07:07:07 UTC) #4
Message was sent while issue was closed.
I landed it for you. Lets hope the buildbots stay green this time around.

Powered by Google App Engine
This is Rietveld 408576698