Switching CSS Variables over to RuntimeEnabledFeatures

Switching CSS Variables over to RuntimeEnabledFeatures

Taking the CSS Variables flag out of InternalSettings and Settings
and using RuntimeEnabledFeatures instead.

BUG=239748
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151228

[alancutter (OOO until 2018), 2013-05-23 10:10:45]

This is a resubmit of https://codereview.chromium.org/14987004/.
The issue that caused a debug assert has been fixed
(https://codereview.chromium.org/15317009/).

[abarth-chromium, 2013-05-23 17:16:27]

This is a CL for eseidel.  :)

[eseidel, 2013-05-23 17:34:08]

lgtm

[commit-bot: I haz the power, 2013-05-23 17:34:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/15687004/1

[commit-bot: I haz the power, 2013-05-23 17:46:43]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[alancutter (OOO until 2018), 2013-05-24 00:19:32]

On 2013/05/23 17:46:43, I haz the power (commit-bot) wrote:
> Retried try job too often on blink_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

Looks like I need approval for Source/Webkit/chromium/public/WebSettings.h
I see Eric is an owner for Source/Webkit/chromium/public/WebRuntimeFeatures.*,
should this cover WebSettings.h as well?

[abarth-chromium, 2013-05-25 02:43:39]

API change LGTM

[commit-bot: I haz the power, 2013-05-25 02:53:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/15687004/13001

[commit-bot: I haz the power, 2013-05-25 05:30:41]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-27 00:16:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/15687004/13001

[commit-bot: I haz the power, 2013-05-27 00:16:36]

Failed to apply patch for Source/core/css/CSSParserMode.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/CSSParserMode.h
  Hunk #1 FAILED at 68.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/css/CSSParserMode.h.rej

Patch:       Source/core/css/CSSParserMode.h
Index: Source/core/css/CSSParserMode.h
diff --git a/Source/core/css/CSSParserMode.h b/Source/core/css/CSSParserMode.h
index
ded9b38e18d347cc3a1ebd807df7781f11cae29f..bcfe502dbeb0cdf309bd9bb956c5c95ddf8cc3a0
100644
--- a/Source/core/css/CSSParserMode.h
+++ b/Source/core/css/CSSParserMode.h
@@ -68,7 +68,6 @@ public:
     bool isCSSStickyPositionEnabled;
     bool isCSSCompositingEnabled;
     bool isCSSGridLayoutEnabled;
-    bool isCSSVariablesEnabled;
     bool needsSiteSpecificQuirks;
 };

[commit-bot: I haz the power, 2013-05-27 00:40:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/15687004/17003

[commit-bot: I haz the power, 2013-05-27 02:45:13]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-27 06:01:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/15687004/17003

[commit-bot: I haz the power, 2013-05-27 07:32:01]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-27 08:22:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/15687004/17003

[commit-bot: I haz the power, 2013-05-27 10:17:13]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-27 22:54:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/15687004/17003

[commit-bot: I haz the power, 2013-05-27 22:54:18]

Failed to apply patch for Source/core/css/CSSParser.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/CSSParser.h
  Hunk #1 FAILED at 116.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/css/CSSParser.h.rej

Patch:       Source/core/css/CSSParser.h
Index: Source/core/css/CSSParser.h
diff --git a/Source/core/css/CSSParser.h b/Source/core/css/CSSParser.h
index
428dae913f3300e9fd84493dce7635d986edd86d..374ea879fcc520e395f885ff9045b2a81fd737d5
100644
--- a/Source/core/css/CSSParser.h
+++ b/Source/core/css/CSSParser.h
@@ -116,7 +116,6 @@ public:
     bool parseQuotes(CSSPropertyID, bool important);
 
     static bool parseValue(StylePropertySet*, CSSPropertyID, const String&,
bool important, Document*);
-    bool cssVariablesEnabled() const;
     void storeVariableDeclaration(const CSSParserString&,
PassOwnPtr<CSSParserValueList>, bool important);
 
     PassRefPtr<CSSValue> parseAttr(CSSParserValueList* args);

[commit-bot: I haz the power, 2013-05-27 23:55:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/15687004/49001

[commit-bot: I haz the power, 2013-05-28 01:55:29]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-28 02:45:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/15687004/49001

[commit-bot: I haz the power, 2013-05-28 04:42:41]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-28 06:43:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/15687004/49001

[commit-bot: I haz the power, 2013-05-28 08:32:11]

Change committed as 151228