Issue 15675011: Add permission message for Music Manager Private API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15675011: Add permission message for Music Manager Private API. (Closed)

Created:
7 years, 6 months ago by rpaquay

Modified:
7 years, 6 months ago

Reviewers:
commit-bot: I haz the power, Matt Perry, rpaquay1

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
https://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add permission message for Music Manager Private API. BUG=242540 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203013

Patch Set 1 #

Patch Set 2 : Fix unit test. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/permissions/chrome_api_permissions.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/common/extensions/permissions/permission_message.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/permissions/permission_set_unittest.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rpaquay

Add permission message for Music Manager Private API. Somewhat trivial change. The message text has ...

7 years, 6 months ago (2013-05-29 19:30:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/15675011/1

7 years, 6 months ago (2013-05-29 20:30:17 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=132291

7 years, 6 months ago (2013-05-29 21:22:34 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/15675011/14002

7 years, 6 months ago (2013-05-29 21:59:10 UTC) #5

Message was sent while issue was closed.

Change committed as 203013

Expand Messages | Collapse Messages