chrome/common/extensions/permissions/chrome_api_permissions.cc - Issue 15675011: Add permission message for Music Manager Private API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_api_permissions.cc

Issue 15675011: Add permission message for Music Manager Private API. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Fix unit test. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/permissions/chrome_api_permissions.cc

diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc

index f0564a36dc16e1ba459561e688353e5fbe8bbe26..c141c34323664a977ce2276f9d6f883ed3ec7625 100644

--- a/chrome/common/extensions/permissions/chrome_api_permissions.cc

+++ b/chrome/common/extensions/permissions/chrome_api_permissions.cc

@@ -152,7 +152,9 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

{ APIPermission::kMetricsPrivate, "metricsPrivate",

APIPermissionInfo::kFlagCannotBeOptional },

{ APIPermission::kMusicManagerPrivate, "musicManagerPrivate",

- APIPermissionInfo::kFlagCannotBeOptional },

+ APIPermissionInfo::kFlagCannotBeOptional,

+ IDS_EXTENSION_PROMPT_WARNING_MUSIC_MANAGER_PRIVATE,

+ PermissionMessage::kMusicManagerPrivate },

{ APIPermission::kSystemPrivate, "systemPrivate",

APIPermissionInfo::kFlagCannotBeOptional },

{ APIPermission::kCloudPrintPrivate, "cloudPrintPrivate",