Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Side by Side Diff: pkg/compiler/lib/src/cps_ir/backward_null_check_remover.dart

Issue 1567103006: Null check remover understands JS fragments. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 library dart2js.cps_ir.backward_null_check_remover; 1 library dart2js.cps_ir.backward_null_check_remover;
2 2
3 import 'cps_ir_nodes.dart'; 3 import 'cps_ir_nodes.dart';
4 import 'optimizers.dart'; 4 import 'optimizers.dart';
5 import '../common/names.dart'; 5 import '../common/names.dart';
6 import '../universe/selector.dart'; 6 import '../universe/selector.dart';
7 import 'type_mask_system.dart'; 7 import 'type_mask_system.dart';
8 import 'cps_fragment.dart'; 8 import 'cps_fragment.dart';
9 9
10 /// Removes null checks that are follwed by another instruction that will 10 /// Removes null checks that are follwed by another instruction that will
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 Reference<Primitive> getNullCheckedOperand(Primitive prim) { 55 Reference<Primitive> getNullCheckedOperand(Primitive prim) {
56 if (prim is NullCheck) return prim.value; 56 if (prim is NullCheck) return prim.value;
57 if (prim is GetLength) return prim.object; 57 if (prim is GetLength) return prim.object;
58 if (prim is GetField) return prim.object; 58 if (prim is GetField) return prim.object;
59 if (prim is GetIndex) return prim.object; 59 if (prim is GetIndex) return prim.object;
60 if (prim is SetField) return prim.object; 60 if (prim is SetField) return prim.object;
61 if (prim is SetIndex) return prim.object; 61 if (prim is SetIndex) return prim.object;
62 if (prim is InvokeMethod && !selectorsOnNull.contains(prim.selector)) { 62 if (prim is InvokeMethod && !selectorsOnNull.contains(prim.selector)) {
63 return prim.dartReceiverReference; 63 return prim.dartReceiverReference;
64 } 64 }
65 if (prim is ForeignCode) {
66 return prim.isNullGuardOnNullFirstArgument() ? prim.arguments[0] : null;
67 }
65 return null; 68 return null;
66 } 69 }
67 70
68 /// It has been determined that the null check in [prim] made redundant by 71 /// It has been determined that the null check in [prim] made redundant by
69 /// [newNullCheck]. Eliminate [prim] if it is not needed any more. 72 /// [newNullCheck]. Eliminate [prim] if it is not needed any more.
70 void tryEliminateRedundantNullCheck(Primitive prim, Primitive newNullCheck) { 73 void tryEliminateRedundantNullCheck(Primitive prim, Primitive newNullCheck) {
71 if (prim is NullCheck) { 74 if (prim is NullCheck) {
72 Primitive value = prim.value.definition; 75 Primitive value = prim.value.definition;
73 LetPrim let = prim.parent; 76 LetPrim let = prim.parent;
74 prim..replaceUsesWith(value)..destroy(); 77 prim..replaceUsesWith(value)..destroy();
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 void visitLetHandler(LetHandler node) { 120 void visitLetHandler(LetHandler node) {
118 nullCheckedValue = null; 121 nullCheckedValue = null;
119 } 122 }
120 123
121 visitInvokeContinuation(InvokeContinuation node) { 124 visitInvokeContinuation(InvokeContinuation node) {
122 if (!node.isRecursive) { 125 if (!node.isRecursive) {
123 nullCheckedValue = nullCheckedValueAt[node.continuation.definition]; 126 nullCheckedValue = nullCheckedValueAt[node.continuation.definition];
124 } 127 }
125 } 128 }
126 } 129 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart » ('j') | pkg/compiler/lib/src/js/js.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698