Null check remover understands JS fragments.

Null check remover understands JS fragments.

This is an SSA-parity item.

R=asgerf@google.com

Committed: https://github.com/dart-lang/sdk/commit/1576feeb2317433e677d42c5e330a644b8d6a415

Reverted.

Committed: https://github.com/dart-lang/sdk/commit/7f724c151dc63f0994d33986cfaa72015a5503d0

[sra1, 2016-01-09 01:17:22]

sra@google.com changed reviewers:
+ asgerf@google.com

[asgerf, 2016-01-11 16:28:25]

LGTM

https://chromiumcodereview.appspot.com/1567103006/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/js/js.dart (right):

https://chromiumcodereview.appspot.com/1567103006/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/js/js.dart:174: //
Would be it be worthwhile to unfold all the way to the first subexpression?

E.g. something like "#.length + 1" or "#.foo.bar()" would not be caught.

[sra1, 2016-01-11 19:25:27]

https://chromiumcodereview.appspot.com/1567103006/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/js/js.dart (right):

https://chromiumcodereview.appspot.com/1567103006/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/js/js.dart:174: //
On 2016/01/11 16:28:25, asgerf wrote:
> Would be it be worthwhile to unfold all the way to the first subexpression?
> 
> E.g. something like "#.length + 1" or "#.foo.bar()" would not be caught.

I will see if it makes a difference.

[sra1, 2016-01-11 21:42:30]

Description was changed from

==========
Null check remover understands JS fragments.

This is an SSA-parity item.
==========

to

==========
Null check remover understands JS fragments.

This is an SSA-parity item.

R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1576feeb2317433e677d42c5e330a644b8d6a415
==========

[sra1, 2016-01-11 21:42:31]

Committed patchset #1 (id:1) manually as
1576feeb2317433e677d42c5e330a644b8d6a415 (presubmit successful).

[sra1, 2016-01-11 22:15:49]

Description was changed from

==========
Null check remover understands JS fragments.

This is an SSA-parity item.

R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1576feeb2317433e677d42c5e330a644b8d6a415
==========

to

==========
Null check remover understands JS fragments.

This is an SSA-parity item.

R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1576feeb2317433e677d42c5e330a644b8d6a415

Reverted.
==========

[sra1, 2016-01-11 22:33:29]

Description was changed from

==========
Null check remover understands JS fragments.

This is an SSA-parity item.

R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1576feeb2317433e677d42c5e330a644b8d6a415

Reverted.
==========

to

==========
Null check remover understands JS fragments.

This is an SSA-parity item.

R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1576feeb2317433e677d42c5e330a644b8d6a415

Reverted.

Committed:
https://github.com/dart-lang/sdk/commit/7f724c151dc63f0994d33986cfaa72015a5503d0
==========

[sra1, 2016-01-11 22:33:30]

Committed patchset #4 (id:60001) manually as
7f724c151dc63f0994d33986cfaa72015a5503d0 (presubmit successful).