Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 15670013: Merge 149838 "Reland "Clear highlight when the highlighted node ..." (Closed)

Created:
7 years, 6 months ago by trchen
Modified:
7 years, 6 months ago
Reviewers:
trchen
CC:
blink-reviews
Visibility:
Public.

Description

Merge 149838 "Reland "Clear highlight when the highlighted node ..." > Reland "Clear highlight when the highlighted node gets removed from the document" > > Some web pages use a mask element to intercept tap gesture and then hide > the element immediately. The orphaned highlight can be very annoying. > For example, pages that show a popup often use a full screen transparent > element to intercept events, and will hide the popup if the user attempt > to tap on the main document. If we don't remove highlight from the hidden > element, the whole screen will be covered by a highlight. > > This patch clears highlight from a layer when the tap node is no longer valid. > > TEST=webkit_unit_tests:LinkHighlightTest.resetDuringNodeRemoval > BUG=232926 > R=jamesr@chromium.org > > Originally reviewed in https://chromiumcodereview.appspot.com/14582012 > Later reverted in https://codereview.chromium.org/14921004/ > The test failure was due to failing to unregister mocked URLs after test. > > Review URL: https://chromiumcodereview.appspot.com/14729006 TBR=trchen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M Source/WebKit/chromium/src/LinkHighlight.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/LinkHighlight.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/LinkHighlightTest.cpp View 3 chunks +77 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
trchen
7 years, 6 months ago (2013-05-31 02:06:00 UTC) #1
trchen
7 years, 6 months ago (2013-05-31 02:06:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r151511.

Powered by Google App Engine
This is Rietveld 408576698