Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Issue 14729006: Reland "Clear highlight when the highlighted node gets removed from the document" (Closed)

Created:
7 years, 7 months ago by trchen
Modified:
7 years, 7 months ago
Reviewers:
jamesr
CC:
blink-reviews, dglazkov, wjmaclean
Visibility:
Public.

Description

Reland "Clear highlight when the highlighted node gets removed from the document" Some web pages use a mask element to intercept tap gesture and then hide the element immediately. The orphaned highlight can be very annoying. For example, pages that show a popup often use a full screen transparent element to intercept events, and will hide the popup if the user attempt to tap on the main document. If we don't remove highlight from the hidden element, the whole screen will be covered by a highlight. This patch clears highlight from a layer when the tap node is no longer valid. TEST=webkit_unit_tests:LinkHighlightTest.resetDuringNodeRemoval BUG=232926 R=jamesr@chromium.org Originally reviewed in https://chromiumcodereview.appspot.com/14582012 Later reverted in https://codereview.chromium.org/14921004/ The test failure was due to failing to unregister mocked URLs after test. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M Source/WebKit/chromium/src/LinkHighlight.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/LinkHighlight.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/LinkHighlightTest.cpp View 3 chunks +77 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
trchen
This patch is identical to the original patch except appending Platform::current()->unitTestSupport()->unregisterAllMockedURLs() to the end of ...
7 years, 7 months ago (2013-05-07 01:15:31 UTC) #1
jamesr
lgtm
7 years, 7 months ago (2013-05-07 01:41:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/14729006/1
7 years, 7 months ago (2013-05-07 01:42:13 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 02:27:14 UTC) #4
Message was sent while issue was closed.
Change committed as 149838

Powered by Google App Engine
This is Rietveld 408576698