components/autofill/core/browser/autofill_external_delegate_unittest.cc - Issue 15660018: [autofill] Add support for PSL domain matching for password autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate_unittest.cc

Issue 15660018: [autofill] Add support for PSL domain matching for password autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed test expectation to match intention and comment Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_external_delegate.cc ('k') | components/autofill/core/browser/autofill_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_external_delegate_unittest.cc

diff --git a/components/autofill/core/browser/autofill_external_delegate_unittest.cc b/components/autofill/core/browser/autofill_external_delegate_unittest.cc

index 907720f535ae15ae73e8a62f8d6a2f7416279d60..8db0448148adb5e00303aca1db8f62316073d126 100644

--- a/components/autofill/core/browser/autofill_external_delegate_unittest.cc

+++ b/components/autofill/core/browser/autofill_external_delegate_unittest.cc

@@ -300,8 +300,11 @@ TEST_F(AutofillExternalDelegateUnitTest,

// suggestions.

TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegatePasswordSuggestions) {

static const base::string16 kUsername = ASCIIToUTF16("username");

+ static const base::string16 kSignonRealm = ASCIIToUTF16("http://foo.com/");

std::vector<base::string16> suggestions;

suggestions.push_back(kUsername);

+ std::vector<base::string16> realms;

+ realms.push_back(kSignonRealm);

FormFieldData field;

field.is_focusable = true;

@@ -324,6 +327,7 @@ TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegatePasswordSuggestions) {

_));

external_delegate_->OnShowPasswordSuggestions(suggestions,

+ realms,

field,

element_bounds);