components/autofill/core/browser/autofill_external_delegate.cc - Issue 15660018: [autofill] Add support for PSL domain matching for password autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate.cc

Issue 15660018: [autofill] Add support for PSL domain matching for password autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed test expectation to match intention and comment Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_external_delegate.cc

diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc

index 346873d2e69bbd7315463646caa73c3c0978ec24..29568c2521fd5cd04ae1096d2bba0a3fe874a48b 100644

--- a/components/autofill/core/browser/autofill_external_delegate.cc

+++ b/components/autofill/core/browser/autofill_external_delegate.cc

@@ -133,6 +133,7 @@ void AutofillExternalDelegate::OnSuggestionsReturned(

void AutofillExternalDelegate::OnShowPasswordSuggestions(

const std::vector<base::string16>& suggestions,

+ const std::vector<base::string16>& realms,

const FormFieldData& field,

const gfx::RectF& element_bounds) {

autofill_query_field_ = field;

@@ -150,7 +151,7 @@ void AutofillExternalDelegate::OnShowPasswordSuggestions(

element_bounds_,

autofill_query_field_.text_direction,

suggestions,

- empty,

+ realms,

empty,

password_ids,

GetWeakPtr());