Make the Data Saver Promo buttons always visible at the bottom of the promo

Make the Data Saver Promo buttons always visible at the bottom of the promo

Remove the FRE promo card from local and Canary builds

BUG=574247
Committed: https://crrev.com/18727c615c70e8bb1851eef8dc8af5d284843b22
Cr-Commit-Position: refs/heads/master@{#368402}

[megjablon, 2016-01-07 00:47:06]

Patchset #1 (id:1) has been deleted

[megjablon, 2016-01-07 00:47:19]

megjablon@chromium.org changed reviewers:
+ newt@chromium.org

[newt (away), 2016-01-07 05:18:31]

looks good after comment

https://chromiumcodereview.appspot.com/1562733003/diff/20001/chrome/android/j...
File chrome/android/java/res/layout/data_reduction_promo_screen.xml (right):

https://chromiumcodereview.appspot.com/1562733003/diff/20001/chrome/android/j...
chrome/android/java/res/layout/data_reduction_promo_screen.xml:27: <LinearLayout
This LinearLayout can be reomved. Its children can be positioned directly inside
of the enclosing RelativeLayout.

[megjablon, 2016-01-07 20:22:01]

https://chromiumcodereview.appspot.com/1562733003/diff/20001/chrome/android/j...
File chrome/android/java/res/layout/data_reduction_promo_screen.xml (right):

https://chromiumcodereview.appspot.com/1562733003/diff/20001/chrome/android/j...
chrome/android/java/res/layout/data_reduction_promo_screen.xml:17:
<org.chromium.chrome.browser.widget.TintedImageButton
Moved the tinted image button down so that it's layered on top of the
LinearLayout and it's onClick gets called.

https://chromiumcodereview.appspot.com/1562733003/diff/20001/chrome/android/j...
chrome/android/java/res/layout/data_reduction_promo_screen.xml:27: <LinearLayout
On 2016/01/07 05:18:31, newt wrote:
> This LinearLayout can be reomved. Its children can be positioned directly
inside
> of the enclosing RelativeLayout.

Removing this LinearLayout causes the ScrollView to disappear. This is the only
solution I could find where the ScrollView expands to fit the content if it has
the room and the buttons always remain visible at the bottom. If I give the
buttons the alignParentBottom property, then the FRE expands to always fill the
whole height of the screen, even when it doesn't need to.

[newt (away), 2016-01-07 20:49:07]

lgtm after invalid layout param is removed

https://chromiumcodereview.appspot.com/1562733003/diff/20001/chrome/android/j...
File chrome/android/java/res/layout/data_reduction_promo_screen.xml (right):

https://chromiumcodereview.appspot.com/1562733003/diff/20001/chrome/android/j...
chrome/android/java/res/layout/data_reduction_promo_screen.xml:27: <LinearLayout
On 2016/01/07 20:22:01, megjablon wrote:
> On 2016/01/07 05:18:31, newt wrote:
> > This LinearLayout can be reomved. Its children can be positioned directly
> inside
> > of the enclosing RelativeLayout.
> 
> Removing this LinearLayout causes the ScrollView to disappear. This is the
only
> solution I could find where the ScrollView expands to fit the content if it
has
> the room and the buttons always remain visible at the bottom. If I give the
> buttons the alignParentBottom property, then the FRE expands to always fill
the
> whole height of the screen, even when it doesn't need to.

Ah, right. I forgot that the height of this whole layout is wrap_content.

https://chromiumcodereview.appspot.com/1562733003/diff/40001/chrome/android/j...
File chrome/android/java/res/layout/data_reduction_promo_screen.xml (right):

https://chromiumcodereview.appspot.com/1562733003/diff/40001/chrome/android/j...
chrome/android/java/res/layout/data_reduction_promo_screen.xml:27:
android:layout_alignParentTop="true"
whoops. remove this.

[megjablon, 2016-01-07 21:35:11]

https://chromiumcodereview.appspot.com/1562733003/diff/40001/chrome/android/j...
File chrome/android/java/res/layout/data_reduction_promo_screen.xml (right):

https://chromiumcodereview.appspot.com/1562733003/diff/40001/chrome/android/j...
chrome/android/java/res/layout/data_reduction_promo_screen.xml:27:
android:layout_alignParentTop="true"
On 2016/01/07 20:49:07, newt wrote:
> whoops. remove this.

Done.

[megjablon, 2016-01-08 19:21:32]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2016-01-08 19:21:32]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1562733003/#ps60001
(title: "whoops")

[commit-bot: I haz the power, 2016-01-08 19:22:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1562733003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1562733003/60001

[commit-bot: I haz the power, 2016-01-08 19:26:56]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-01-08 19:28:04]

Description was changed from

==========
Make the Data Saver Promo buttons always visible at the bottom of the promo

Remove the FRE promo card from local and Canary builds

BUG=574247
==========

to

==========
Make the Data Saver Promo buttons always visible at the bottom of the promo

Remove the FRE promo card from local and Canary builds

BUG=574247

Committed: https://crrev.com/18727c615c70e8bb1851eef8dc8af5d284843b22
Cr-Commit-Position: refs/heads/master@{#368402}
==========

[commit-bot: I haz the power, 2016-01-08 19:28:05]

Patchset 3 (id:??) landed as
https://crrev.com/18727c615c70e8bb1851eef8dc8af5d284843b22
Cr-Commit-Position: refs/heads/master@{#368402}