Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/android/java/res/layout/data_reduction_promo_screen.xml

Issue 1562733003: Make the Data Saver Promo buttons always visible at the bottom of the promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <org.chromium.chrome.browser.preferences.datareduction.DataReductionPromoView 6 <org.chromium.chrome.browser.preferences.datareduction.DataReductionPromoView
7 xmlns:android="http://schemas.android.com/apk/res/android" 7 xmlns:android="http://schemas.android.com/apk/res/android"
8 xmlns:chrome="http://schemas.android.com/apk/res-auto" 8 xmlns:chrome="http://schemas.android.com/apk/res-auto"
9 android:background="#c000" > 9 android:background="#c000" >
10 10
11 <ScrollView 11 <RelativeLayout
12 android:layout_height="wrap_content" 12 android:layout_height="wrap_content"
13 android:layout_width="match_parent" 13 android:layout_width="match_parent"
14 android:layout_gravity="center" 14 android:layout_gravity="center"
15 android:fillViewport="true"> 15 android:background="#FFFF" >
16 16
17 <RelativeLayout 17 <org.chromium.chrome.browser.widget.TintedImageButton
megjablon 2016/01/07 20:22:01 Moved the tinted image button down so that it's la
18 android:id="@+id/close_button"
19 android:layout_height="56dp"
20 android:layout_width="56dp"
21 android:layout_alignParentEnd="true"
22 android:layout_alignParentTop="true"
23 android:background="?android:attr/selectableItemBackground"
24 android:contentDescription="@string/close"
25 android:src="@drawable/btn_close" />
26
27 <LinearLayout
newt (away) 2016/01/07 05:18:31 This LinearLayout can be reomved. Its children can
megjablon 2016/01/07 20:22:01 Removing this LinearLayout causes the ScrollView t
newt (away) 2016/01/07 20:49:07 Ah, right. I forgot that the height of this whole
18 android:layout_height="wrap_content" 28 android:layout_height="wrap_content"
19 android:layout_width="match_parent" 29 android:layout_width="match_parent"
20 android:background="#FFFF" > 30 android:layout_alignParentTop="true"
31 android:orientation="vertical" >
21 32
22 <org.chromium.chrome.browser.widget.TintedImageButton 33 <ScrollView
23 android:id="@+id/close_button" 34 android:id="@+id/data_reduction_promo_scroll"
24 android:layout_height="56dp" 35 android:layout_height="0dp"
25 android:layout_width="56dp" 36 android:layout_width="match_parent"
26 android:layout_alignParentEnd="true" 37 android:layout_weight="1"
27 android:layout_alignParentTop="true" 38 android:fillViewport="true"
28 android:background="?android:attr/selectableItemBackground" 39 android:requiresFadingEdge="vertical"
29 android:contentDescription="@string/close" 40 android:fadingEdgeLength="20dp" >
30 android:src="@drawable/btn_close" /> 41
42 <LinearLayout
43 android:id="@+id/data_reduction_promo_content"
44 android:layout_height="wrap_content"
45 android:layout_width="match_parent"
46 android:paddingEnd="24dp"
47 android:paddingStart="24dp"
48 android:paddingTop="64dp" >
49
50 <ImageView
51 android:id="@+id/data_reduction_illustration"
52 android:layout_height="wrap_content"
53 android:layout_width="wrap_content"
54 android:layout_gravity="center"
55 android:adjustViewBounds="true"
56 android:contentDescription="@null"
57 android:src="@drawable/data_reduction_illustration" />
58
59 <LinearLayout
60 android:id="@+id/text_wrapper"
61 android:layout_height="wrap_content"
62 android:layout_width="wrap_content"
63 android:orientation="vertical" >
64
65 <TextView
66 android:layout_height="wrap_content"
67 android:layout_width="match_parent"
68 android:layout_marginBottom="8dp"
69 android:text="@string/data_reduction_promo_title"
70 android:textColor="@color/default_text_color"
71 android:textSize="@dimen/data_reduction_promo_title_ text_size" />
72
73 <TextView
74 android:layout_height="wrap_content"
75 android:layout_width="match_parent"
76 android:layout_marginBottom="30dp"
77 android:lineSpacingMultiplier="1.3"
78 android:text="@string/data_reduction_promo_summary"
79 android:textColor="#646464"
80 android:textSize="@dimen/data_reduction_promo_normal _text_size" />
81 </LinearLayout>
82 </LinearLayout>
83 </ScrollView>
31 84
32 <LinearLayout 85 <LinearLayout
33 android:id="@+id/data_reduction_promo_content" 86 android:id="@+id/data_reduction_promo_buttons"
34 android:layout_height="wrap_content" 87 android:layout_height="wrap_content"
35 android:layout_width="match_parent" 88 android:layout_width="match_parent"
36 android:layout_below="@+id/close_button"
37 android:layout_marginTop="8dp"
38 android:paddingEnd="24dp"
39 android:paddingStart="24dp" >
40
41 <ImageView
42 android:id="@+id/data_reduction_illustration"
43 android:layout_height="wrap_content"
44 android:layout_width="wrap_content"
45 android:layout_gravity="center"
46 android:adjustViewBounds="true"
47 android:contentDescription="@null"
48 android:src="@drawable/data_reduction_illustration" />
49
50 <LinearLayout
51 android:id="@+id/text_wrapper"
52 android:layout_height="wrap_content"
53 android:layout_width="wrap_content"
54 android:orientation="vertical" >
55
56 <TextView
57 android:layout_height="wrap_content"
58 android:layout_width="match_parent"
59 android:layout_marginBottom="8dp"
60 android:text="@string/data_reduction_promo_title"
61 android:textColor="@color/default_text_color"
62 android:textSize="@dimen/data_reduction_promo_title_text _size" />
63
64 <TextView
65 android:layout_height="wrap_content"
66 android:layout_width="match_parent"
67 android:layout_marginBottom="30dp"
68 android:lineSpacingMultiplier="1.3"
69 android:text="@string/data_reduction_promo_summary"
70 android:textColor="#646464"
71 android:textSize="@dimen/data_reduction_promo_normal_tex t_size" />
72 </LinearLayout>
73 </LinearLayout>
74
75 <LinearLayout
76 android:layout_height="wrap_content"
77 android:layout_width="match_parent"
78 android:layout_below="@id/data_reduction_promo_content"
79 android:layout_gravity="bottom"
80 android:orientation="horizontal" 89 android:orientation="horizontal"
81 android:clipToPadding="false" 90 android:clipToPadding="false"
82 android:padding="16dp" 91 android:padding="16dp"
83 android:gravity="end" > 92 android:gravity="end" >
84 93
85 <Button 94 <Button
86 android:id="@+id/no_thanks_button" 95 android:id="@+id/no_thanks_button"
87 android:layout_height="match_parent" 96 android:layout_height="match_parent"
88 android:layout_width="wrap_content" 97 android:layout_width="wrap_content"
89 android:layout_marginEnd="8dp" 98 android:layout_marginEnd="8dp"
90 android:minHeight="40dp" 99 android:minHeight="40dp"
91 android:text="@string/no_thanks" 100 android:text="@string/no_thanks"
92 android:textColor="@color/light_normal_color" 101 android:textColor="@color/light_normal_color"
93 android:textSize="@dimen/data_reduction_promo_button_text_si ze" 102 android:textSize="@dimen/data_reduction_promo_button_text_si ze"
94 style="@style/ButtonCompatBorderless" /> 103 style="@style/ButtonCompatBorderless" />
95 104
96 <org.chromium.ui.widget.ButtonCompat 105 <org.chromium.ui.widget.ButtonCompat
97 android:id="@+id/enable_button" 106 android:id="@+id/enable_button"
98 android:layout_height="match_parent" 107 android:layout_height="match_parent"
99 android:layout_width="wrap_content" 108 android:layout_width="wrap_content"
100 android:elevation="0dp" 109 android:elevation="0dp"
101 android:minHeight="40dp" 110 android:minHeight="40dp"
102 android:text="@string/data_reduction_enable_button" 111 android:text="@string/data_reduction_enable_button"
103 android:textColor="#FFFFFF" 112 android:textColor="#FFFFFF"
104 android:textSize="@dimen/data_reduction_promo_button_text_si ze" 113 android:textSize="@dimen/data_reduction_promo_button_text_si ze"
105 chrome:buttonColor="@color/light_active_color" /> 114 chrome:buttonColor="@color/light_active_color" />
106 </LinearLayout> 115 </LinearLayout>
107 </RelativeLayout> 116 </LinearLayout>
108 </ScrollView> 117 </RelativeLayout>
109 </org.chromium.chrome.browser.preferences.datareduction.DataReductionPromoView> 118 </org.chromium.chrome.browser.preferences.datareduction.DataReductionPromoView>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698