Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1560663002: Drop precompiler-related code from dart_precompiled binary. (Closed)

Created:
4 years, 11 months ago by Florian Schneider
Modified:
4 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Drop precompiler-related code from dart_precompiled binary. Also drop stub-code generation code, which pulled in large parts of the assembler as well. This reduces the size of dart_precompiled/libdart_precompiled by around 100K on x64. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/3e3ca58375a2a8c2abd10df9c5df2969062a18ec

Patch Set 1 #

Patch Set 2 : omit stub-code generation code #

Total comments: 2

Patch Set 3 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M runtime/dart-runtime.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M runtime/vm/stub_code.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Florian Schneider
4 years, 11 months ago (2016-01-05 12:48:37 UTC) #2
rmacnak
lgtm https://chromiumcodereview.appspot.com/1560663002/diff/20001/runtime/vm/stub_code.cc File runtime/vm/stub_code.cc (right): https://chromiumcodereview.appspot.com/1560663002/diff/20001/runtime/vm/stub_code.cc#newcode52 runtime/vm/stub_code.cc:52: #endif // DART_PRECOMPILED else UNREACHABLE
4 years, 11 months ago (2016-01-05 18:47:03 UTC) #5
Florian Schneider
https://codereview.chromium.org/1560663002/diff/20001/runtime/vm/stub_code.cc File runtime/vm/stub_code.cc (right): https://codereview.chromium.org/1560663002/diff/20001/runtime/vm/stub_code.cc#newcode52 runtime/vm/stub_code.cc:52: #endif // DART_PRECOMPILED On 2016/01/05 18:47:03, rmacnak wrote: > ...
4 years, 11 months ago (2016-01-06 10:38:54 UTC) #6
Florian Schneider
4 years, 11 months ago (2016-01-06 10:40:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
3e3ca58375a2a8c2abd10df9c5df2969062a18ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698