Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 15605003: Make Exception and Error objects ScriptWrappable. (Closed)

Created:
7 years, 7 months ago by Tom Sepez
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch, kinuko, feature-media-reviews_chromium.org, dglazkov+blink, f(malita), adamk+blink_chromium.org, pdr, Stephen Chennney
Visibility:
Public.

Description

Make Exception and Error objects ScriptWrappable. This allows binding integrity checks to be applied to these objects. Initially, I had skipped these because they are small, and in the case of the exceptions, seemingly interrelated. So apply these as a group, so we can take them out as a group if need be later on. BUG=236671 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -32 lines) Patch
M Source/core/dom/DOMCoreException.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/dom/DOMError.h View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/dom/DOMError.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/EventException.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/fileapi/FileError.h View 2 chunks +7 lines, -4 lines 0 comments Download
M Source/core/fileapi/FileException.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/html/MediaError.h View 2 chunks +8 lines, -4 lines 0 comments Download
M Source/core/html/MediaKeyError.h View 2 chunks +8 lines, -4 lines 0 comments Download
M Source/core/svg/SVGException.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/xml/XPathException.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/modules/geolocation/PositionError.h View 1 chunk +10 lines, -8 lines 0 comments Download
M Source/modules/webdatabase/SQLError.h View 2 chunks +7 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/SQLException.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Tom Sepez
Adam. Please review.
7 years, 7 months ago (2013-05-21 20:24:54 UTC) #1
abarth-chromium
lgtm
7 years, 7 months ago (2013-05-21 20:29:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/15605003/1
7 years, 7 months ago (2013-05-21 21:13:40 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 23:51:07 UTC) #4
Message was sent while issue was closed.
Change committed as 150839

Powered by Google App Engine
This is Rietveld 408576698