Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 15540004: Auto-generate HTMLFrameSetElement::namedPropertyGetter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/CodeGeneratorV8.pm
diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm b/Source/bindings/scripts/CodeGeneratorV8.pm
index b756b75c1f3763d1c5ee2f67c4a61f66c61a8c25..af5920cabb46c360c375e708674a95ce774ba8ee 100644
--- a/Source/bindings/scripts/CodeGeneratorV8.pm
+++ b/Source/bindings/scripts/CodeGeneratorV8.pm
@@ -3426,12 +3426,12 @@ v8::Handle<v8::Object> wrap($implClassName* impl, v8::Handle<v8::Object> creatio
END
}
- my $indexer;
kojih 2013/05/21 07:35:12 remeoved unused variable.
my @enabledPerContextFunctions;
my @normalFunctions;
my $needsDomainSafeFunctionSetter = 0;
# Generate methods for functions.
foreach my $function (@{$interface->functions}) {
+ next if $function->signature->name eq "";
kojih 2013/05/21 07:35:12 To prevent anonymous getter function from being ad
GenerateFunction($function, $interface, "");
if ($function->signature->extendedAttributes->{"PerWorldBindings"}) {
GenerateFunction($function, $interface, "ForMainWorld");
@@ -3449,10 +3449,6 @@ END
}
}
- if ($function->signature->name eq "item") {
- $indexer = $function->signature;
- }
-
# If the function does not need domain security check, we need to
# generate an access getter that returns different function objects
# for different calling context.
@@ -4624,7 +4620,6 @@ sub IsUnionType
{
my $type = shift; # string or UnionType
if(ref($type) eq "UnionType") {
- die "Currently only 2 values of non-union type is supported as union type.\n" unless @{$type->unionMemberTypes} == 2;
kojih 2013/05/21 07:35:12 # of union members is not limited by 2. http://src
return 1;
}
return 0;

Powered by Google App Engine
This is Rietveld 408576698